Semantic HTML5 markup, CSS custom properties, Flexbox & Vanilla JS

Community feedback

• 

  favour Aniogor•275

  @PhantomOzPosted over 2 years ago

  Nice work Saajeves, Here are my feedbacks:

  • You should fix your accessibility by formatting your code well.
  • You try writing semantically.
  • You did a good job with accessibility except for the part where you gave your tabindex attribute a value of 1, if you use 0 your site still works as expected. We try avoiding values greater than 0 cause it is difficult for people who rely on assistive technology to navigate and operate page content.
  • Your page looks good both on desktop and mobile.
  • Your code is well-structured and very reusable.
  • Suggestion: you should try adding the CSS transition property on img element each time the image changes for ease in.

  Excellent Job by the way 👍, I hope this feedback was helpful.

  0