Skip to content
OverviewSolutions
4
Comments
28
favour Aniogor
@PhantomOz

All comments

  • favour Aniogor•275
    @PhantomOzPosted about 1 year ago

    Hello Chinwe, Great Job. Are you participating in the ongoing Hacktoberfest?

    0
  • favour Aniogor•275
    @PhantomOzPosted over 1 year ago

    Good Job VictorWest ✌️, Here are Helpful tips I think can help improve your challenge:

    1. Your code should be semantic and you should try giving your classes a constant naming convention.
    2. Your code is also not really accessible.
    3. Your layout is responsive, Great Job ✌️.
    4. Your is not well-structured, readable, and reusable. There are minor issues with the color you used for the button and your border-radius. You should try wrapping the whole code inside your body element with a <div class="container"> or a main element for your boxshadow
    Marked as helpful
    1
  • favour Aniogor•275
    @PhantomOzPosted over 2 years ago

    Nice job Rob, here is my feedback:

    • Good job trying to write semantically but, there are some areas where you could have placed semantic elements.
    • You should try fixing your 'accessibility' issues by formatting your code well.
    • You should try fixing your 'HTML' issues by:
      1. This code in the header <a href="##"> <img class="logo" src="" alt="Sneakers logo"> </a> you should remove the second # in the href attribute.
      2. This code also ```<button type="button" class="btn add-to-cart-btn"> <p>Add to cart</p> </button>``` you can't have a block element `p` in an inline element `button` you should fix it.
    • The layout looks good on both Desktop and mobile screens but, I think you can still work on the typography especially the font-weight and font-size of some of the element so it resembles the design. The logo also looks chopped off underneath usually on Desktop screens.
    • You should also structure your code well.

    Good Job by the way 👍, I hope you found this feedback helpful.

    1
  • favour Aniogor•275
    @PhantomOzPosted over 2 years ago

    Hello Hassan,

    • You should try fixing your accessibility issues by formatting your code well.
    • You should also try writing semantic HTML
    • Your site only looks nice on screens that are 1440px and larger.
    • You need to work on your code structure and readability.
    • Try improving your skill with CSS grids.

    Nice job by the way, I hope this feedback was helpful 👍

    Marked as helpful
    0
  • favour Aniogor•275
    @PhantomOzPosted over 2 years ago

    Great Job Gabriel, Here is my feedback:

    • I love the fact that you used ReactJs and still tried writing semantically.
    • Your site is very accessible.
    • It looks good on both Desktop and Mobile devices.
    • Your codes are well-structured and very readable.

    Great Job 👍

    1
  • favour Aniogor•275
    @PhantomOzPosted over 2 years ago

    Nice work Saajeves, Here are my feedbacks:

    • You should fix your accessibility by formatting your code well.
    • You try writing semantically.
    • You did a good job with accessibility except for the part where you gave your tabindex attribute a value of 1, if you use 0 your site still works as expected. We try avoiding values greater than 0 cause it is difficult for people who rely on assistive technology to navigate and operate page content.
    • Your page looks good both on desktop and mobile.
    • Your code is well-structured and very reusable.
    • Suggestion: you should try adding the CSS transition property on img element each time the image changes for ease in.

    Excellent Job by the way 👍, I hope this feedback was helpful.

    0
  • cveller16•10
    @cveller16Submitted over 2 years ago

    This is my first ever coding challenge - hoping to receive supportive feedback for my very necessary corrections. I struggled a lot with making this design accurately responsive for mobile, namely resizing the image and getting the stats to change position when moving from desktop to mobile. I also have yet to figure out how to add color to, or tint(?) an image.

    If anybody is willing to offer help with responsive resolution scaling (mobile @ 375px and desktop @ 1440px), and adding tint to an image, I'd love some assistance!

    Responsive stats preview card component

    2
    favour Aniogor•275
    @PhantomOzPosted over 2 years ago

    Hello Cveller16, you should read about flexbox check w3schools on google

    0
  • Yohan-Marques•150
    @Yohan-MarquesSubmitted over 2 years ago

    I would like your Feedback, to correct something that is messy or wrong in my code and to have a different point of view to aggregate in my knowledge. Thank you in advance. 🙏🙏🙏

    FAQ accordion card main / Display Flex

    1
    favour Aniogor•275
    @PhantomOzPosted over 2 years ago

    Great job Yohan, Here is my feedback:

    • Nice job writing semantically
    • Your code is very accessible and I liked what you did with the dropdown icon animation.
    • Your webpage looks good on every device
    • Your codes are well-structured and readable. Suggestion: would be nice if the content slides down on clicking the dropdown.

    Excellent Job by way, I hope you find this feedback useful 👍

    Marked as helpful
    1
  • xtradam•30
    @xtradamSubmitted over 2 years ago

    I had a great time with this challenge, I felt like I was able to make it close to the design to the best of my ability. The hardest part was trying to get the button to align in the proper place. Lots of experimenting with different flexbox and position attributes.

    Advice Generator app using Bootstrap

    1
    favour Aniogor•275
    @PhantomOzPosted over 2 years ago

    Nice job Xtradam, I just have some feedback:

    • You should try fixing the accessibility issues by formatting your code well, I noticed there is a div with an empty class attribute try removing that.
    • Your codes are very readable, excellent job with that 👍
    • Your site looks nice on desktop and mobile.
    • Just a suggestion: you should add a transition to your #adviceQuote so it eases in when the advice changes.

    Great Job by the way, I hope you find this feedback helpful 👍

    Marked as helpful
    1
  • favour Aniogor•275
    @PhantomOzPosted over 2 years ago

    Hello Nantukchy,

    Here is my feedback:

    1. I love the fact you tried writing semantically but you have to put your 'section' element in the 'main' element, this will fix you 'landmark' accessibility issue.
    2. format your codes well.
    3. Try make the site responsive on mobile devices at least 375px.

    I hope this feedback was helpful, Good job 👍

    0
  • favour Aniogor•275
    @PhantomOzPosted over 2 years ago

    Nice Job Kajaoud,

    • Your code is readable and well-formatted.
    • The site is responsive.
    • You should try writing semantic syntax

    Good Job 👍

    Marked as helpful
    1
  • favour Aniogor•275
    @PhantomOzPosted over 2 years ago

    Hello Youtubbeh, fantastic job by the way.

    I noticed you tried writing semantically good job. Few things I will suggest:

    1. You change the section element class "plan" to a div - this will make your code more semantic and fix the HTML issue you have, and also you can't have a section element without a heading element.
    2. To fix your Accessibility issue, you should put the div with class attribution in a footer element or in the main element.
    3. Also I think you should try to make it responsive for mobile devices using @media-queries in CSS.

    I hope this feedback was helpful 👍

    Marked as helpful
    0