Responsive E-commerce product page solution

Community feedback

• 

  favour Aniogor•275

  @PhantomOzPosted over 2 years ago

  Nice job Rob, here is my feedback:

  • Good job trying to write semantically but, there are some areas where you could have placed semantic elements.
  • You should try fixing your 'accessibility' issues by formatting your code well.
  • You should try fixing your 'HTML' issues by:
    1. This code in the header <a href="##"> <img class="logo" src="" alt="Sneakers logo"> </a> you should remove the second # in the href attribute.
    2. This code also ```<button type="button" class="btn add-to-cart-btn"> <p>Add to cart</p> </button>``` you can't have a block element `p` in an inline element `button` you should fix it.
  • The layout looks good on both Desktop and mobile screens but, I think you can still work on the typography especially the font-weight and font-size of some of the element so it resembles the design. The logo also looks chopped off underneath usually on Desktop screens.
  • You should also structure your code well.

  Good Job by the way 👍, I hope you found this feedback helpful.

  1