-
This challenge was pretty straight forward and I had a really fun time making it. It was a bit easier than the NFT component card in my opinion.
-
I think I did a pretty decent job making everything work I'm not sure if there is any part of my code I could have made much better from my current understanding.
-
Is there anything anyone thinks I can do to better improve my code. Or is there anything that would make my code much easier to read and or understand?
Antonio Novak
@Nova988All comments
- @NellyisDevvSubmitted over 2 years ago@Nova988Posted over 2 years ago
Hello, nice card. I have some things to point out.
- Try to put the card in a div box and center it with flexbox. Card is divided into pieces in the main component. If you create a div and replace the <main> styles on the div. Then center the card with flexbox on the <main>, your card should be centered. Now it is on the bottom of my screen plus I need to scroll down to see the card.
- Change the font-weight of the price tag. It is to bold compared to the design.
Hope it helps.
Marked as helpful1 - @JoseAngaraSubmitted over 2 years ago
Hi, everyone. ¿Is there a better way to use JS in forms? I feel like my code is a little messy.
@Nova988Posted over 2 years agoHello,
In 2022 you should try to avoid using var. Instead of var use let and const.
Here you can read why you shouldn't use it : https://medium.com/@codingsam/awesome-javascript-no-more-var-working-title-999428999994.
Hope it helps.
0 - @ElDullSubmitted over 2 years ago
I'd love feedback on my css and react code, as I am a total beginner regarding those.
@Nova988Posted over 2 years agoHello,
You should look into responsiveness design. If you set the width to 950px, you can see that the dashboard is not fully in the window. You can try looking into grid with using minmax(). I also have a solution, not saying it is perfect, but maybe you can see how i have made it more responsive so it fits the window.
Hope it helps.
Marked as helpful1 - @AthllaSubmitted about 3 years ago
Any feedback will be appriciated
@Nova988Posted about 3 years agoHello, Nice app!
You style the cursor on the light/dark mode button to pointer. It will make it nicer
0 - @LahsivK4070Submitted about 3 years ago
Some suggestions will be of great help. Thanks
@Nova988Posted about 3 years agoHello, nice card!
- Try to add some padding between the image en text in the middle text box.
- The change button needs to be an other color. I think you have the default color for the a tag.
- Also add some box shadow on the payment button and add some spacing between the button and cancel order to fit the design.
Hope it helps.
0 - @KristaCallejaSubmitted about 3 years ago
UPDATE take 2: Addressed accessibility errors; and design. Thanks for the tips FEM community!
UPDATED: Added opacity.
I am having a hard time finding the correct color for the primary-button hover. And also how to arrange the elements in the middle text box (including image). Any tips appreciated.
@Nova988Posted about 3 years agoHello,
For the background color on hover: did you try opacity? And you need to reduce the width of the image in the middle text box. It is set to 100%
Hope it helps
Marked as helpful0 - @koniuszkoSubmitted about 3 years ago
Any comments welcome
@Nova988Posted about 3 years agoHello,
The background is not showing. Did you add it ?
0 - @Babajide777Submitted about 3 years ago
I enjoyed building this project. Kindly let me know if there is anything that I need to improve. Thanks.
@Nova988Posted about 3 years agoNice card!
Maybe just change the font-size and color of the socials text.
0 - @PiotrKukuc12Submitted about 3 years ago
i will be appreciate for any feedback
@Nova988Posted about 3 years agoHello,
Nice card just a few things you could change:
- The background-color needs to be a different color.
- Try to add some vertical padding on the Proceed payment button to match the design.
Hope it helps!
Marked as helpful0 - @dopefreshSubmitted about 3 years ago
Are there any unnecessary elements? Also code review will be really appreciated
@Nova988Posted about 3 years agoHello,
You forgot some things:
- Background image is not covering the whole background and it is repeating.
- The description text needs to be a different color.
- The 'change' button has a different font-weight and an underline.
- The 'Proceed' button has a box-shadow and a different color.
- You need to change the background of the annual plan container.
- Try to center the card using flexbox.
Hope it helps.
Marked as helpful3 - @vinaypuppalSubmitted about 3 years ago
Any feedback is welcome!
@Nova988Posted about 3 years agoHi,
When i click the share button on mobile view. The card goes full width to adjust the size for the share menu. Maybe you can fix this?
0 - @HernanAlex61ChoqueCondori8Submitted about 3 years ago
Hi, I await your recommendations to be able to improve the code (👍≖‿‿≖)👍 👍(≖‿‿≖👍)
@Nova988Posted about 3 years agoHello,
- Try to set the pointer cursor on the share button
Nice Card! I have a question : How did you position the image in the card.
0