Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • deezjasonβ€’ 20

    @deezjason

    Submitted

    What are you most proud of, and what would you do differently next time?

    I am very proud that I was able to do this and get almost everything correctly(except for the font)

    What challenges did you encounter, and how did you overcome them?

    My work got deleted unfortunatelyπŸ₯² but I was able to bounce back and redesign it to be better than before

    What specific areas of your project would you like help with?

    Mostly on how to change the font into the fonts that you get from Google fonts, its the only thing that I struggled with

    P
    Jennaβ€’ 230

    @NandiniCooppen

    Posted

    Hi there,

    Congratulations on completing this challenge. πŸ‘

    Regarding the Google fonts, to use them, first of all, you need to look up and select both from the Google Fonts site

    There is an icon at the top right, indicating, how many fonts you have got, select all fonts you need before clicking the embed code button.

    You will have something similar to

    "@import url('https://fonts.googleapis.com/css2?family=Fraunces:ital,opsz,wght@0,9..144,100..900;1,9..144,100..900&family=Montserrat:ital,wght@0,100..900;1,100..900&display=swap');"
    

    Copy it into your CSS file, at the start.

    You will be able to use the fonts where needed.

    Example:

    body {
      font-family: "Montserrat", sans-serif;
    }
    
    h2 {
      font-family: "Fraunces", serif;
    }
    
    

    If I may suggest some improvements :

    1. Semantic structure

    Use the semantic HTML5 in your structure. To improve the document structure and in return improve its accessibility, consider using <header>, <main>, <article>, and <footer> elements where applicable.

    Read more about semantics here

    Read more about accessibility here

    Read more about headings here

    2. Centring elements using CSS grid or Flexbox

    To centre the design both horizontally and vertically, you can use CSS flexbox as follows on the body.

    body {
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
    }
    

    or grid

    display: grid;
    place-items: center;
    min-height: 100vh;
    

    3. Always do a reset for your CSS

    * {
      margin: 0;
      padding: 0;
      box-sizing: border-box;
    }
    

    4. Using CSS variables

    Try using CSS variables on your next challenge.

    Read more about CSS custom properties here

    For reference, you may check my submission here

    Do not hesitate, if you have any questions.

    I hope these will be helpful to you πŸ˜‰

    Good luck onwards and happy coding πŸ™‚

    0
  • P
    Jennaβ€’ 230

    @NandiniCooppen

    Posted

    Hello thilisadiki,

    Congrats on completing your first challengeπŸ‘

    To center the card properly, you might want to use CSS flexbox or grid.

    Example using CSS Flexbox:

    Add the following code to the body:

    body {
        display: flex;
        justify-content: center;
        align-items: center;
        min-height: 100vh;
    }
    

    You can thus remove the margin from your style :

    .main-card {
        margin: 6rem auto;
    }
    

    Helpful links:

    CSS Flexbox :

    Link1

    Link2

    CSS grid:

    Link1

    You might want to have a look at the following as well:

    Read about accessibility here

    Read about semantics here

    Read about headings here

    I hope these will be helpful to you πŸ˜‰

    Good luck going forward and happy coding πŸ™‚

    0
  • P
    Jennaβ€’ 230

    @NandiniCooppen

    Posted

    Hello nielzon-t,

    Congrats on completing the QR- code challenge πŸ‘

    To properly center the outer and inner box on the page , you may do the following changes:

    body {
        display: flex;
        justify-content: center;
        align-items: center;
        min-height: 100vh;
    }
    
    .outerbox {
        width: 85%;
        background-color: hsl(212, 45%, 89%);
        /* margin: auto; */
        display: flex;
        /* min-width: 300px; */
        /* margin-top: 1.5em; */
        box-shadow: -5px 10px 10px hsl(220, 15%, 55%);
        /* height: 90vh; */
        /* min-height: 400px; */
        justify-content: center;
        padding: 6rem 0;
    }
    
    .innerbox {
        /* max-width: 30%; */
        /* min-width: 275px; */
        height: 50vh;
        /* min-height: 400px; */
        background-color: white;
        display: flex;
        justify-content: center;
        flex-direction: column;
        /* margin: auto; */
        border-radius: 10px;
        box-shadow: -0.5px 1px 3px hsl(220, 15%, 55%);
        align-content: center;
        align-items: center;
        width: 340px;
    }
    
    img {
        width: 300px;
        /* height: 200px; */
        /* display: flex; */
        /* justify-content: center; */
        /* margin: auto; */
        border-radius: 10px;
        margin-top: 10px;
    }
    

    I have added some code to center the elements on the page. I have commented /**/ some of them as they do not seem to be necessary. However you will have to adjust the code as needed to get close to the design.

    You should also specify a unit ex: 16px

    html { font-size: 16; }

    If I may suggest some other improvements :

    1. Semantic structure / Using Semantic HTML5

    Using the semantic HTML5 in your structure. To improve the document structure and in return improve its accessibility, consider using <header>, <main>, <article>, and <footer> elements where applicable. You may use semantic HTML, instead of <div>. some examples of semantic HTML : <main> , <section> , <header>,<nav>, <footer>

    3. Headings

    It is also important to always have an h1 heading in a document before any other level headings tag. Use a <h1> tag for title to provide a descriptive title.

    Helpful links:

    Read more about accessibility here

    Read more about semantics here

    Read more about headings here

    Using CSS variables

    For example, using the style guide provided, you may create your CSS colors variables as follow :

    root {
    --white: hsl(0, 0%, 100%);
    --light-gray: hsl(212, 45%, 89%);
    }
    

    Helpful links:

    Read more about CSS custom properties here

    Read more about CSS Flexbox :

    Link1

    Link2

    I hope these will be helpful to you πŸ˜‰

    Good luck going forward and happy coding πŸ™‚

    Marked as helpful

    1
  • P
    Jennaβ€’ 230

    @NandiniCooppen

    Posted

    Hello tanmayuniyal,

    Congrats on completing the QR- code challenge πŸ‘

    If I may suggest some improvements :

    Improve accessibility

    1. Alternative text

    Adding a meaningful description to the 'alt'.

    For example alt="QR code for Frontend Mentor website"

    2. Semantic structure

    Using the semantic HTML5 in your structure.To improve the document structure and in return improve its accessibility, consider using <header>, <main>, <article>, and <footer> elements where applicable.

    You must not have an h3 heading directly in your structure. It should always start with an h1 heading.

    For example :

    <main>
    <article class="card-section">
    <div class = "container">
    <div class = "box">
    <img src="images/image-qr-code.png" alt="QR code for Frontend Mentor website">
    <h1>
    Improve your front-end skills by building projects.
    </h1>
    <p>
    Scan the QR code to visit Frontend Mentor and take your coding skills to the next level.
    </p>
    </div>
    </div>
    </article> 
    </main>
    

    Read more about accessibility here

    Read more about semantics here

    Read more about headings here

    Using CSS variables

    For example, using the style guide provided, you may create your CSS colors variables as follow :

    root {
    --white: hsl(0, 0%, 100%);
    --light-gray: hsl(212, 45%, 89%);
    }
    
    

    Read more about CSS custom properties here

    Centering elements using Flexbox

    To center the container both horizontally and vertically, you can use CSS flexbox as follow on the body.

    body {
    background-color: hsl(0, 0%, 93%);
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
    }
    

    You may then remove all the margin properties from the .container, leaving only the following code :

    .container {
    background-color: hsl(209, 47%, 90%);
    padding: 80px;
    box-shadow: 5px 5px 10px rgba(0, 0, 0, 0.23);
    }
    

    Read more about min-height here

    Read more about CSS Flexbox :

    Link1

    Link2

    For info, you can use the shorthand form for padding and margin values.

    Read more about padding here

    Read more about margin here

    I hope these will be helpful to you πŸ˜‰

    Good luck going forward and happy coding πŸ™‚

    Marked as helpful

    0
  • P
    Jennaβ€’ 230

    @NandiniCooppen

    Posted

    Hello yanthetechbro,

    Congrats on completing the QR- code challenge πŸ‘

    If I may suggest some improvements :

    Improve accessibility

    1. Alternative text

    Adding a more meaningful description to the 'alt'.

    For example alt="QR code for Frontend Mentor website"

    2. Semantic structure

    Using the semantic HTML5 in your structure.To improve the document structure and in return improve its accessibility, consider using <header>, <main>, <article>, and <footer> elements where applicable.

    For example :

    <main>
    <article class="card-section">
    <div class="container">
    <div class="qr-code">
    <figure>
    <img
    src="./image/image-qr-code.png"
    alt="Image of qr-code"
    class="image"
    />
    </figure>
    <div class="text">
    <h1>Improve your front-end skills by buliding projects</h1>
    <p>
    Scan the QR code to visit Frontend Mentor and take your coding
    skills to the next level
    </p>
    </div>
    </div>
    </div>
    </article> 
    </main>
    

    Read more about accessibility here

    Read more about semantics here

    Using CSS variables

    For example, using the style guide provided, you may create your CSS colors variables as follow :

    root {
    --white: hsl(0, 0%, 100%);
    --light-gray: hsl(212, 45%, 89%);
    }
    
    

    Read more about CSS custom properties here

    I hope these will be helpful to you πŸ˜‰

    Good luck going forward and happy coding πŸ™‚

    0
  • P
    Jennaβ€’ 230

    @NandiniCooppen

    Posted

    Hello teempe,

    Congrats on completing the QR- code challenge πŸ‘

    If I may suggest some improvements :

    Improve accessibility

    1. Semantic structure

    Using the semantic HTML5 in your structure.To improve the document structure and in return improve its accessibility, consider using <header>, <main>, <article>, and <footer> elements where applicable.

    For example :

    <main>
    <article class="card-section">
    <div class="container">
    <img src="./images/image-qr-code.png" alt="QR code visit Frontend Mentor">
    <h1 class="head">Improve your front-end skills by building projects</h1>
    <p class="info">Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    </div>
    </article> 
    </main>
    
    <footer>
    <div class="attribution">
    Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. 
    Coded by <a href="https://github.com/teempe">teempe</a>.
    </div>
    </footer>
    
    

    Read more about accessibility here

    Read more about semantics here

    Using CSS variables

    For example, using the style guide provided, you may create your CSS colors variables as follow :

    root {
    --white: hsl(0, 0%, 100%);
    --light-gray: hsl(212, 45%, 89%);
    }
    
    

    Read more about CSS custom properties here

    Using min-height for the body

    Replace the height: 100vh with min-height:100vh;

    body { min-height:100vh;}

    Read more about min-height here

    I hope these will be helpful to you πŸ˜‰

    Good luck going forward and happy coding πŸ™‚

    Marked as helpful

    0
  • P
    Jennaβ€’ 230

    @NandiniCooppen

    Posted

    Hello Ola135,

    Congrats on completing the QR- code challenge πŸ‘

    Here are some improvements that I would like to suggest :

    Improve accessibility

    1. Alternative text

    Adding a meaningful description to the 'alt'.

    For example alt="QR code for Frontend Mentor website"

    2. Semantic structure

    Using the semantic HTML5 in your structure.To improve the document structure and in return improve its accessibility, consider using <header>, <main>, <article>, and <footer> elements where applicable.

    For example :

    <main>
    <article class="card-section">
    <div class="container">
    <div class="card">
    <img src="images/image-qr-code.png" alt="">
    <div class="text">
    <h2>Improve your front-end skills by building projects</h2>
    <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    </div>
    </div>
    </div>
    </article> 
    </main>
    

    It is also important to always have an h1 heading in a document before a h2 tag.

    Read more about accessibility here

    Read more about semantics here

    Read more about headings here

    Using CSS variables

    For example, using the style guide provided, you may create your CSS colors variables as follow :

    root {
    --white: hsl(0, 0%, 100%);
    --light-gray: hsl(212, 45%, 89%);
    }
    
    

    Read more about CSS custom properties here

    Centering using Flexbox

    You have already applied CSS flexbox to the body to center the card. To center both horizontally and vertically, just add justify-content: center;

    You may then remove the margin: 0 auto; from .container.

    body {
    font-family: 'Outfit', sans-serif;
    background-color: hsl(212, 45%, 89%);
    min-height: 100vh;
    display: flex;
    align-items: center;
    justify-content: center;
    }
    

    I hope these will be helpful to you πŸ˜‰

    Good luck going forward and happy coding πŸ™‚

    Marked as helpful

    1
  • P
    Jennaβ€’ 230

    @NandiniCooppen

    Posted

    Hello Pranav,

    Congrats on completing the QR- code challenge πŸ‘

    Improve accessibility

    1. Alternative text

    Adding a more meaningful description to the 'alt'.

    For example alt="QR code for Frontend Mentor website"

    2. Semantic structure

    Using the semantic HTML5 in your structure.To improve the document structure and in return improve its accessibility, consider using <header>, <main>, <article>, and <footer> elements where applicable.

    For example:

    <main>
    <article class="card-section">
    <div class="card">
    <img class="image_border" src="images/image-qr-code.png" alt="QR code for Frontend Mentor website">
    <div class="container">
    <h1 class="content">Improve your front-end skills by building projects</h1>
    <p class="content2">Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    </div>
    </div>
    </article> 
    </main>
    

    Read more about accessibility here

    Centering the card vertically using CSS flexbox

    Read more about CSS Flexbox :

    Link1

    Link2

    body {
    background-color: var(--light-gray);
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
    }
    

    You may then remove the margin: 50px auto from .card and remove .container{ padding-top: 10px 20px 0px 20px; (invalid property) and no usage. }

    The correct form for padding property shorthand should be : padding : 10px 20px 0px 20px;

    Read more about padding here

    I suggest that you may reduce the size of the card and QR image as well. To make the image responsive instead of giving a fix width to it , give the width:100%; max-width:350px; height: auto;

    For example :

    .card { width: 350px; }
    
    .image_border {
    width: 100%;
    border-radius: 40px;
    padding: 20px;
    max-width: 350px;
    height: auto;
    }
    

    I hope these will be helpful to you πŸ˜‰

    Good luck going forward and happy coding πŸ™‚

    1
  • P
    Jennaβ€’ 230

    @NandiniCooppen

    Posted

    Hello Omrankabo,

    Congrats on completing the QR- code challenge πŸ‘

    If I may suggest some improvements :

    improve accessibility

    1. Alternative text

    Adding a more meaningful description to the 'alt'.

    For example alt="QR code for Frontend Mentor website"

    main -Using min-height You may remove the width: 100vw; and height: 100vh; instead add min-hieght:100vh;

    I hope these will be helpful to you πŸ˜‰

    Good luck going forward and happy coding πŸ™‚

    Marked as helpful

    1
  • P
    Jennaβ€’ 230

    @NandiniCooppen

    Posted

    Hello thomasmestdagh,

    Congrats on completing the QR- code challenge πŸ‘

    Here are some improvements that I would like to suggest :

    improve accessibility

    1. Alternative text

    Adding a more meaningful description to the 'alt'.

    For example alt="QR code for Frontend Mentor website"

    2. Semantic structure

    I have noticed that you have used the semantic HTML5 tag "section" in your structure. However to improve the document structure and in return improve its accessibility, consider using <header>, <main>, <article>, and <footer> elements where applicable.

    3. Headings Instead of the <p> tag for the title, consider using the <h1> tag to provide a descriptive title.

    For example :

    <main>
    <section class="card-section">
    <div class="card">
    <img class="card-img" src="images/image-qr-code.png" alt="QR code for Frontend Mentor website">
    <div class="card-content">
    <h1 class="card-title">Improve your front-end skills by building projects</h1>
    <p class="card-text">Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    </div>   
    </div>
    </section> 
    </main>
    

    Read more about accessibility here

    Read more about semantics here

    Read more about headings here

    Using CSS variables

    For example, using the style guide provided, you may create your CSS colors variables as follow :

    root {
    --white: hsl(0, 0%, 100%);
    --light-gray: hsl(212, 45%, 89%);
    }
    

    Read more about CSS custom properties here

    Using min-height

    From .card-section remove width: 100vw and height: 100vh.

    Add min-height:100vh;

    .card-section {min-height:100vh;}

    Read more about min-height here

    Fix box shadow

    I notice that your rgba value is not okay for your box-shadow. You have a value in excess.

    box-shadow: 0 0 30px 0 rgba(0,0,0,0.0.2);

    It should be like this :

    .card { box-shadow: 0 0 30px 0 rgba(0,0,0,0.2); }

    Read more about box-shadow here

    Remove space on line 19 in your style.css file

    I noticed there's a space between background-color: hsl(212, 45%, 89%); and display flex; for .card-section

    I hope these will be helpful to you πŸ˜‰

    Good luck going forward and happy coding πŸ™‚

    Marked as helpful

    0
  • P
    Jennaβ€’ 230

    @NandiniCooppen

    Posted

    Hello Nabil,

    Congrats on completing the QR- code challenge πŸ‘

    Here are some improvements that I would like to suggest :

    1. Using Semantic HTML5

    You may use semantic HTML, instead of <div>. some examples of semantic HTML : <main> , <section> , <header>,<nav>, <footer>

    You may read more about semantics here

    2. Using CSS variables

    For example, using the style guide provided, you may create your CSS colors variables as follow :

    root {
    --white: hsl(0, 0%, 100%);
    --light-gray: hsl(212, 45%, 89%);
    }
    

    Read more about CSS custom properties here

    3. Min-height instead of height

    Instead of height:100vh; replace it with min-height: 100vh; for the body.

    body {min-height: 100vh;}

    You may read more about min-height here

    4. Remove the space on line 14 and fix the font size value units. (style.css)

    I notice that there is a space between background-color: hsl(212, 45%, 89%); and font-size: Also, it seems like you forgot to specify the unit of the font size. font-size:15;--> is an invalid property. You should mention a unit such as px, em, or rem.

    5. For the img , replace height: 50% with height:auto;

    If height: auto; the element will automatically adjust its height to allow its content to be displayed correctly.

    I hope these will be helpful to you πŸ˜‰

    Good luck going forward and happy coding πŸ™‚

    Marked as helpful

    1
  • RosvaldasBβ€’ 10

    @RosvaldasB

    Submitted

    first time trying to use sass, looking for tips if it was possible to make a better noticable change to the style.

    P
    Jennaβ€’ 230

    @NandiniCooppen

    Posted

    Hello RosvaldasB,

    Congrats on completing the QR- code challenge πŸ‘

    Here are some improvements that I would like to suggest :

    1. Using Semantic HTML5

    You may use semantic HTML, instead of <div>. some examples of semantic HTML : <main> , <section> , <header>,<nav>, <footer>

    You have skipped a heading level by using the h2 tag, this will cause an accessibility issue. Your document should have an h1 heading.

    You may read more about semantics here

    You may read more about accessibility here

    2. Using CSS variables For example, using the style guide provided, you may create your CSS colors variables as follow :

    root {
    --white: hsl(0, 0%, 100%);
    --light-gray: hsl(212, 45%, 89%);
    }
    

    Read more about CSS custom properties here

    3. Centering the card

    I will suggest adding the following lines of CSS to the body, just below the justify-content: center;

    body {
    align-items: center;
    min-height: 100vh;
    }
    

    This will center the card vertically on the page as needed. You may then remove the following lines of code from .wrapper

    position: absolute;

    top: 50%;

    transform: translate(0, -50%);

    I hope these will be helpful to you πŸ˜‰

    Good luck going forward. and happy coding πŸ™‚

    Marked as helpful

    0