Hello Nabil,
Congrats on completing the QR- code challenge 👏
Here are some improvements that I would like to suggest :
1. Using Semantic HTML5
You may use semantic HTML, instead of <div>. some examples of semantic HTML : <main> , <section> , <header>,<nav>, <footer>
You may read more about semantics here
2. Using CSS variables
For example, using the style guide provided, you may create your CSS colors variables as follow :
root {
--white: hsl(0, 0%, 100%);
--light-gray: hsl(212, 45%, 89%);
}
Read more about CSS custom properties here
3. Min-height instead of height
Instead of height:100vh; replace it with min-height: 100vh; for the body.
body {min-height: 100vh;}
You may read more about min-height here
4. Remove the space on line 14 and fix the font size value units. (style.css)
I notice that there is a space between background-color: hsl(212, 45%, 89%); and font-size: Also, it seems like you forgot to specify the unit of the font size. font-size:15;--> is an invalid property. You should mention a unit such as px, em, or rem.
5. For the img , replace height: 50% with height:auto;
If height: auto; the element will automatically adjust its height to allow its content to be displayed correctly.
I hope these will be helpful to you 😉
Good luck going forward and happy coding 🙂
Marked as helpful
@Sherif-Nabil
Posted
@NandiniCooppen Thank you for taking the time to review my code. Your suggestions were very helpful and I was able to make some significant improvements. I'm really happy with the results and I really appreciate your time and effort. 🙏