QR Code page with CSS Flex

Community feedback

• 

  Jenna•230

  @NandiniCooppenPosted over 1 year ago

  Hello yanthetechbro,

  Congrats on completing the QR- code challenge 👏

  If I may suggest some improvements :

  Improve accessibility

  1. Alternative text

  Adding a more meaningful description to the 'alt'.

  For example alt="QR code for Frontend Mentor website"

  2. Semantic structure

  Using the semantic HTML5 in your structure.To improve the document structure and in return improve its accessibility, consider using <header>, <main>, <article>, and <footer> elements where applicable.

  For example :

  <main>
  <article class="card-section">
  <div class="container">
  <div class="qr-code">
  <figure>
  <img
  src="./image/image-qr-code.png"
  alt="Image of qr-code"
  class="image"
  />
  </figure>
  <div class="text">
  <h1>Improve your front-end skills by buliding projects</h1>
  <p>
  Scan the QR code to visit Frontend Mentor and take your coding
  skills to the next level
  </p>
  </div>
  </div>
  </div>
  </article> 
  </main>
  

  Read more about accessibility here

  Read more about semantics here

  Using CSS variables

  For example, using the style guide provided, you may create your CSS colors variables as follow :

  root {
  --white: hsl(0, 0%, 100%);
  --light-gray: hsl(212, 45%, 89%);
  }
  
  

  Read more about CSS custom properties here

  I hope these will be helpful to you 😉

  Good luck going forward and happy coding 🙂

  0