Hello teempe,
Congrats on completing the QR- code challenge 👏
If I may suggest some improvements :
Improve accessibility
1. Semantic structure
Using the semantic HTML5 in your structure.To improve the document structure and in return improve its accessibility, consider using <header>, <main>, <article>, and <footer> elements where applicable.
For example :
<main>
<article class="card-section">
<div class="container">
<img src="./images/image-qr-code.png" alt="QR code visit Frontend Mentor">
<h1 class="head">Improve your front-end skills by building projects</h1>
<p class="info">Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</div>
</article>
</main>
<footer>
<div class="attribution">
Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
Coded by <a href="https://github.com/teempe">teempe</a>.
</div>
</footer>
Read more about accessibility here
Read more about semantics here
Using CSS variables
For example, using the style guide provided, you may create your CSS colors variables as follow :
root {
--white: hsl(0, 0%, 100%);
--light-gray: hsl(212, 45%, 89%);
}
Read more about CSS custom properties here
Using min-height for the body
Replace the height: 100vh with min-height:100vh;
body { min-height:100vh;}
Read more about min-height here
I hope these will be helpful to you 😉
Good luck going forward and happy coding 🙂
Marked as helpful
