Skip to content
OverviewSolutions
51
Comments
30
Korney Chervonenko
@KorneyChervonenko

All comments

  • Korney Chervonenko•960
    @KorneyChervonenkoPosted 6 months ago

    Hello friend, instead of .addEventListener('click', () => {displayAdvice();}) why don't just do .addEventListener('click', displayAdvice) ?

    0
  • Korney Chervonenko•960
    @KorneyChervonenkoPosted 6 months ago

    Hello friend,

    1. It seems to me that you have added event listener to every unread notification but what if you have hundreds or thousands of those? Your JS would be inefficient. It’s better to add only one event listener to some container of notification elements and after click event just find out which notification was clicked exactly
    2. I think when user clicks on the unread notification remove mark must be removed and counter decreases by one. Am I wrong?
    0
  • Korney Chervonenko•960
    @KorneyChervonenkoPosted 6 months ago

    Hello friend, I think when user clicks on the unread notification remove mark must be removed and counter decreases by one. Am I wrong?

    1
  • Korney Chervonenko•960
    @KorneyChervonenkoPosted 6 months ago

    Hello friend, It seems to me that

    1. you have added event listener to every unread notification but what if you have hundreds or thousands of those? Your JS would be inefficient. It’s better to add only one event listener to some container of notification elements in your case "ul" and after click event just find out which notification was clicked exactly
    2. unread notifications counter doesn't work
    0
  • Ali Reza•470
    @AliRezaCodingSubmitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    I'm happy to done this challenge, next time I'll try to have a better performance. If you have any feedback please do not hesitate to share with me 😀.

    Notification page with HTML CSS & JS

    1
    Korney Chervonenko•960
    @KorneyChervonenkoPosted 6 months ago

    Hello friend, It seems to me that you have added event listener to every unread notification but what if you have hundreds or thousands of those? Your JS would be inefficient. It’s better to add only one event listener to some container of notification elements and after click event just find out which notification was clicked exactly

    Marked as helpful
    0
  • Bigyan Dulal•410
    @bigyandulal2Submitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    It was simple . But was quite stuck, i will use percentage units next time when i will move from desktop to smaller devices.

    What challenges did you encounter, and how did you overcome them?

    The challenge was how to make chess image of a girl there and i did that using position absolute and it's parent to position relative.

    What specific areas of your project would you like help with?

    Feel free to give your suggestion and feedback, i am always down and open to learning new ways of doing the same project.

    This is the responsive notification done using css preprocessor scss

    1
    Korney Chervonenko•960
    @KorneyChervonenkoPosted 6 months ago

    Hello friend, It seems to me that you have added event listener to every unread notification but what if you have hundreds or thousands of those? Your JS would be inefficient. It’s better to add only one event listener to some container of notification elements and after click event just find out which notification was clicked exactly

    0
  • Korney Chervonenko•960
    @KorneyChervonenkoPosted 6 months ago

    Hello friend, There is a requirement in readme: “current day's bar highlighted in a different colour to the other bars”. How do you think “current day” is a some random day of week or it must be changed dynamically when page is loaded in browser? In other words “current day” is today ?

    1
  • Yash Babani•790
    @Yashbabani0Submitted 6 months ago
    What specific areas of your project would you like help with?

    any suggestions for improvement are welcome

    Expenses Chart Component

    1
    Korney Chervonenko•960
    @KorneyChervonenkoPosted 6 months ago

    Hello friend, There is a requirement in readme: “current day's bar highlighted in a different colour to the other bars”. How do you think “current day” is a some random day of week or it must be changed dynamically when page is loaded in browser? In other words “current day” is today ?

    Marked as helpful
    0
  • Michael Johnson•970
    @mikej321Submitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    I'm proud of the design and that I got to learn a new library (recharts).

    What challenges did you encounter, and how did you overcome them?

    I struggled with getting the tooltip to look like it did in the design but I was able to style it by making a custom tooltip via a function. I also struggled and failed when it came to getting the tooltip to statically stay in place above each bar.

    What specific areas of your project would you like help with?

    I wasn't able to get the tooltip to display over each individual bar properly and if anyone knows how to do it, I'd love to read your explanation and tips! Other than that, if anyone spots any errors that I made while using Recharts, i'd love a more experienced developer to guide me in the right direction.

    Thanks everyone!

    Expenses Chart Component w/ React & Vanilla CSS

    1
    Korney Chervonenko•960
    @KorneyChervonenkoPosted 6 months ago

    Hello friend, There is a requirement in readme: “current day's bar highlighted in a different colour to the other bars”. How do you think “current day” is a some random day of week or it must be changed dynamically when page is loaded in browser? In other words “current day” is today ?

    0
  • Korney Chervonenko•960
    @KorneyChervonenkoPosted 6 months ago

    Hello friend, There is a requirement in readme: “current day's bar highlighted in a different colour to the other bars”. How do you think “current day” is a some random day of week or it must be changed dynamically when page is loaded in browser? In other words “current day” is today ?

    0
  • Ebrahim Ali•40
    @EbrahimAli-1Submitted 7 months ago
    What are you most proud of, and what would you do differently next time?

    I'm proud of my efforts in this project and I'm happy that I could finish it and that I have learned a lot during this journey.

    What challenges did you encounter, and how did you overcome them?

    I faced not little challenges in this project especially in Java Script logic and lots of possibilities the user can input. I searched and tried to figure the problem and how to arrange the code logically

    What specific areas of your project would you like help with?

    I will appreciate if you try it and give me your feedback. And if you find any problems I will be happy to get notified of it. Thanks a lot.💗

    Age Calculator using Html, Css & Js

    1
    Korney Chervonenko•960
    @KorneyChervonenkoPosted 7 months ago

    Hello friend. Does your input validation take into account difference between leap and regular year?

    0
  • GregFJr•150
    @GregFJrSubmitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    Effectively implementing javascript for the error handling

    What challenges did you encounter, and how did you overcome them?

    Mobile view to match the provided design

    What specific areas of your project would you like help with?

    responsiveness

    Responsive Design using Flexbox and Javascript

    1
    Korney Chervonenko•960
    @KorneyChervonenkoPosted 8 months ago

    Hello friend. You have forgotten about customizing list marks ✓.

    0