Skip to content
OverviewSolutions
10
Comments
5
Kira Tantari
@KirativeWD

All comments

  • Ashum91•50
    @Ashum91
    What are you most proud of, and what would you do differently next time?

    I am proud of being able to complete this solution and they appear to be similar.

    What challenges did you encounter, and how did you overcome them?

    I had difficulty trying to centre the image and round its corners, I tried using class selector as per the HTML (.svg) but this wasn't working. I had also tried setting the width but this threw it odd completely.

    What specific areas of your project would you like help with?

    How should I have rounded the corners of the image? Also how to centre the name by the image of Gregg so it's inline.

    CSS Flex

    1
    Kira Tantari•180
    @KirativeWD

    Hi there!

    Great job completing this challenge.

    To apply rounded corners to the image, you'll want to use border-radius on the svg like you did on .container.

    To get the author image and name aligned horizontally, you can wrap them in a div with a class name of your choice and display flex with align-items: center; e.g.

    <div class="author">
  <img>
  <p></p>
</div>

    .author {
  display: flex;
  align-items: center;
}
    Marked as helpful
  • Gabriel Romme Reyes•110
    @Gabriel-Romme-Reyes
    What are you most proud of, and what would you do differently next time?

    I learned about the difference of inline and block elements in this one because i had a problem when adding the background color yellow on the span at first it was an h4 element but upon adding the background color it took up the whole horizontal margin that is where i learned that h4 is a block element and that is when i switch it to span instead. i also learnt a bit more about css such as box-shadow and indentation.

    What challenges did you encounter, and how did you overcome them?

    A bit of a challenge with adding the background color of the learning tag because at first it was an h4 element but when i add the background color it takes up the whole horizontal space that is when i go and checked the internet about the difference of inline and block elements that is why i just used span

    What specific areas of your project would you like help with?

    Are there any ways to change the box-shadow of the ".content" class only when hovering on the h1 element without using js?

    Blog Preview with only css hover effects

    1
    Kira Tantari•180
    @KirativeWD

    Hi there!

    Great job on completing this challenge.

    "Are there any ways to change the box-shadow of the ".content" class only when hovering on the h1 element without using js?"

    Technically, yes.

    .content {
  pointer-events: none;
}

.content:hover {
  box-shadow: 1rem 1rem black;
}

h1 {
  pointer-events: auto;
}

h1:hover {
  color: hsl(47, 88%, 63%);
}

    However, that is overly complicated and what you could do instead is apply the color change to the h1 when .content is hovered. As a user, this makes more sense because I expect the entire card to be clickable and not just the h1.

    .content:hover h1 {
  color: hsl(47, 88%, 63%)
}
  • Mohammad Waris Fayiz•570
    @fayiz770
    What are you most proud of, and what would you do differently next time?

    Congratulations to me for completing this challenge This challenge was a little tricky but I did that.

    I am proud, that I did this project, It has a lot of details in it, and I find that I solved those.

    What challenges did you encounter, and how did you overcome them?

    I was stuck a little to accessing the index of components that comes from data.json, but did that after searching a little on Google and MDN docs.

    What specific areas of your project would you like help with?

    I want improvements related to the border of every summary result, specifically in assigning borders at the edges of every summary, how can I implement that?

    Results Summary

    1
    Kira Tantari•180
    @KirativeWD

    Hi there!

    You asked how you can implement styling each summary result with a border.

    Looking at your CSS, you currently have...

    .items {
  border: 1px gray;
}

    However, the shorthand for border requires a border-style which is an easy fix!

    .items {
  border: 1px solid gray;
}

    I hope this helps.

    Happy coding!

  • P
    JacobKnittle•110
    @JacobKnittle
    What are you most proud of, and what would you do differently next time?

    I am improving with my figma file use.

    What challenges did you encounter, and how did you overcome them?

    getting the li and anchor tags to work together on a hover which I used the inherit value so that the text would also change on an li hover

    What specific areas of your project would you like help with?

    not much on this one pretty straight forward for me

    Social links profile using html and vanilla

    1
    Kira Tantari•180
    @KirativeWD

    Hi there!

    Great job completing this project.

    I noticed you mentioned that you initially had some difficulty getting the hover to work and I wanted to give you a tip from what I saw in your CSS. Currently, the li has the hover state. This can make it confusing for users (if this were an active page) because when the li changes colors, you'd expect to be able to click anywhere for the link to work—but it doesn't work that way. And if a user were to tab to the links, the colors would not change. So what can be updated to improve user experience and make the hover state easier to apply?

    a {
  display: block;
}

    Anchor tags have an initial display value of inline. This makes it so that its width is constricted to its content. When you change the value of display to block, the anchor tags will now behave as any regular block-level element and fill its parent's width and padding can be used to achieve the intended height. However, you will encounter a problem because you're using flex and setting defined heights/widths. This can easily be fixed by adjusting the CSS like so...

    .social-links {
  width: 100%;
}

/* remove all li styles */

    .social-links only needs width: 100% because it's a flex child. But why remove all styles from the li? They're all going to be applied to the anchor tag which is how we'll make applying hover styles much easier! I will show you what selector to use instead.

    li:not(:last-of-type) { // <-- Selects all li except the last in the list
  margin-bottom: 1rem; // <-- So we can get the space between each element
}

a {
  display: block; // <-- To allow block-level styling applications
  background: #333;
  color: white;
  padding-block: 1rem;
  border-radius: 8px;
  transition: all 200ms ease-in-out; // <-- Just for fancy transitioning
}

a:is(:hover, :focus-visible) { // <-- Applies styles when hovering and tabbing
  color: black;
  background-color: #c4f82a;
}

    With the prior applications, you now have hoverable links that are clickable within the entire box and change color when hovered and tabbed to.

    Marked as helpful
  • P
    Celeste Rhoades•40
    @Celeste-Rhoades
    What are you most proud of, and what would you do differently next time?

    I feel I did a decent job. Feedback is welcome

    What challenges did you encounter, and how did you overcome them?

    Moving from mobile first to desktop layout was slightly difficult.

    What specific areas of your project would you like help with?

    Tips on how to write better css

    Css flexbox, HTML

    1
    Kira Tantari•180
    @KirativeWD

    Hi there!

    Great job finishing the project. You mentioned that you would like tips on writing better CSS and that you had some difficulty moving from mobile first to desktop.

    When moving from mobile to desktop, it's best to leave the CSS as simple as possible. You may be tempted to add styling that will be responsive when the screen size grows larger, but until you find a good groove, responsive styles can always be added within the media queries.

    1. I see you applied flex to the body element, but this is unnecessary. When flex is applied to an element, it condenses its width to the content, and with a width of 375px applied to the section container, extra space is on the left and right when the screen grows larger than 375px. For mobile view, the recipe should stretch across the screen until mid-tablet range. So, I would suggest removing those stylings. Doing so already puts you on a better trail.

    2. You have your media query set to happen at 1440px. The challenge style guide mentions that the desktop design was designed at 1440px, but this does not mean you must use that as a breakpoint. You might find it easier to follow the philosophy of adding a breakpoint when the design breaks or starts to look awkward. This is why I mentioned the recipe stretching across the screen until mid-tablet range. And if you look at the image around 1312px, it stops growing. This tells you that that is the image's max initial width. Your breakpoint should happen before then.

    3. A lot is happening at the breakpoint. Most of the changes will not be required if the CSS were simplified. For example, the body, main, .mobile, and .desktop selectors all have style applications that are unnecessary save for the border-radius. And in actuality, .desktop and .mobile could be replaced with a singular class e.g. .recipe-card

    4. You might wonder how you would center the recipe if flex is not used (because flex isn't needed for this project). What you would do instead is set a max-width on one of the containing elements (main or section) along with margin-inline: auto; Doing so will align the recipe horizontally. All you would need to do then is move the recipe down with margin.

    Sorry if this is a lot! I like to be as thorough as possible and I hope this helps!

    If you have any further questions, please feel free to ask. CSS is super fun. :)

    Marked as helpful