@xStephxSubmitted 4 months ago
Latest comments
- @Sahitya2006Submitted almost 3 years ago@Hamza-NoahPosted almost 3 years ago
Hey,
let me give you feedback on the things I see you need to edit:
1- I see that you have not added the curve background to the body so make sure you add it and customise it in different screen sizes until you make it identical to the design on all screens
2- there is this content --> at the bottom of the page so make sure next time you do not have any content that doesn't proper the project
3- I have checked the HTML code and there is a comment that has no benefit to the project I mean it doesn't describe anything so why you did keep it make sure you remove it and only use comments when you need them
4- for the footer there isn't any need to use the footer in this small tiny project
5- and most importantly do not use an internal stylesheet you should create another file and put all the CSS code in it make sure always to isolate the CSS code in a specific file to make the project structure organized and structured correctly
I hope those tips will help you make this project and all the next projects created and structured in the right way!
Good Job
0 - @kjdeepakSubmitted almost 3 years ago@Hamza-NoahPosted almost 3 years ago
Hey this looks nice you just need to do simple edits on the design
increase the size of the card until you make it identical to the design increase the border radius on the left side of the card
try to increase the padding between the numbers and the text below it increase the line-height of the paragraphHope this will help
Marked as helpful0 - @Sh0lexSubmitted about 3 years ago@Hamza-NoahPosted about 3 years ago
Hello
here is my feedback on your solution first, increase the padding around the content of the card. second, try to increase the border radius of the image and the card itself. and for the last thing to edit in the design the challenge by front end mentor should be at the bottom of the page.
after that check the report and follow the steps one by one until you have 0 issues. hope that helps
Marked as helpful0 - @rabbanisanSubmitted about 3 years ago@Hamza-NoahPosted about 3 years ago
Hello
let me give you my feedback
The first thing I have noticed is that you have not to use the right background if you could not find it as I guess it exists in the images file to replace this irrelevant background. increase the height and width of the card to make it identical to the design. increase the border radius of the card and use a box shadow for the card to try to make it as close as possible to the design.
finally move to the report and check it one by one and fix all the accessibility issues and the HTML issues until you have a clear report.
hope that helps
Marked as helpful1 - @ndrewpachecoSubmitted about 3 years ago@Hamza-NoahPosted about 3 years ago
Hey first of all, check the report and follow the steps until you have 0 issues. for the design try to decrease the space after the head of the card. decrease the size of the size of 3 days left to make the font bold on ETH and finally decrease the size of the image and write the full name I see you missed the last name
good job
Marked as helpful1
