Profile card component

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted about 2 years ago

  Hi

  This looks good to me except the component needs a little margin so it doesn’t touch the sides of the screen on some mobiles

  In your html those stats should be an unordered list with 3 list items inside. The words cannot be in paragraphs on their own as they don’t make sense on their own and have to be read with the number (so number and word both should sit within the same meaningful element - an li)

  Marked as helpful

  2
• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  Hi, Hamza! 👋

  Nice work on this challenge! 👍

  One suggestion I have is to add some padding on the body element to prevent the card from touching the edges of the browser. Currently, on mobile landscape view, the card is touching the top edge of my browser.

  I hope this helps!

  Marked as helpful

  1
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  This comment was deleted about 2 years ago

  0

  ---

  

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  @Hamza-Noah Look the description of your solution and see what you wrote.

  0

  

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  @Hamza-Noah Look your solution description. This is what is written there:

  ------------------------- QUOTE -------------------

  👾 Hello, Frontend Mentor coding community. This is my solution for the Profile Card Component.

  Feel free to leave any feedback and help me improve my solution or make the code clean!

  😁 I had a lots of fun building this challenge! I changed almost all design with the FRESH PRINCE THEME

  😪 I had some issues position the circles as background so I just export the background from Figma. My bad.

  I added some features:

  🎨 Custom hover on profile image using the general sibling selector. 👨‍🔬 Custom hover effect on profile background! I'll be happy to hear any feedback and advice!

  "

  0