QR cord component

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello Hamza-Noah,

  Congratulation on completing this challenge. Excellent work!I have some suggestions regarding your solution if you don’t mind:

  • Page should contain <h1>. In this challenge , as it’s supposed to be a part of a whole page, you may use<h1>with sr-only class hidden visually and present for assistive tech users. And then use <h2> instead of <h1>

  • The alternate text should be present on the image(as it’s an informative image).It should tells the users where it takes : like Qr code to frontend mentor

  CSS:

  • Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs.

  • Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  Aside these , Good work! Hopefully this feedback helps

  Marked as helpful

  0