Responsive Card with HTML & CSS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Muhammad, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • img element must have an alt attribute, it's very important!
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • you can remove margin-block from container class because with grid they are superfluous
  • add hover effect on the button

  Overall you did well 😁 Hope this help!

  Marked as helpful

  1

  ---

  

  Muhammad Rabbani R.•50

  @rabbanisanPosted over 2 years ago

  @denielden Thanks for your Advice, it helps me to improve my code

  1
• 

  Hamza-Noah•300

  @Hamza-NoahPosted over 2 years ago

  Hello

  let me give you my feedback

  The first thing I have noticed is that you have not to use the right background if you could not find it as I guess it exists in the images file to replace this irrelevant background. increase the height and width of the card to make it identical to the design. increase the border radius of the card and use a box shadow for the card to try to make it as close as possible to the design.

  finally move to the report and check it one by one and fix all the accessibility issues and the HTML issues until you have a clear report.

  hope that helps

  Marked as helpful

  1

  ---

  

  Muhammad Rabbani R.•50

  @rabbanisanPosted over 2 years ago

  @Hamza-Noah Thanks for your Advice, it helps me to fix all the issues

  0