Skip to content
OverviewSolutions
31
Comments
88

Karol Binkowski

@GrzywNCzęstochowa, Poland1,620 points

I've been using Vim for about 2 years now, mostly because I can't figure out how to exit it.

I’m currently learning...

Angular, React Native, DSA

Latest solutions

View more solutions

Latest comments

  • Karol Binkowski•1,620
    @GrzywN

    Great job!

    I would suggest querying all the elements first and then passing them as function parameters. Then you can use the same elements and it is not necessary to query them again. This is generally considered a good practice.

    It is also better to avoid complicated regular expressions, as they almost always do not work as intended. I would suggest using one of the popular npm libraries in this case.

    Keep coding and have a nice day!

  • Karol Binkowski•1,620
    @GrzywN

    Hey Kira!

    Things worth considering:

    • Adding ESLint and Prettier to your project to make code practices and formatting consistent
    • Splitting big components into smaller ones
    • Extracting app logic into utils and hooks (like calculating relative dates etc.)

    Have a nice day and keep coding!

  • Karol Binkowski•1,620
    @GrzywN

    Great job @darryncodes!

    I think you should consider changing '+' and '-' buttons, since they are really hard to click, especially on mobile. Try to focus them with the 'tab' key and you'll see.

    Helpful materials for you:

    • https://nerdcave.com/tailwind-cheat-sheet
    • https://atomicdesign.bradfrost.com/chapter-2/
    • https://blog.logrocket.com/using-prettier-eslint-automate-formatting-fixing-javascript/
    • https://www.npmjs.com/package/prettier-plugin-organize-imports

    Have a nice day and keep coding!

    Marked as helpful
  • Karol Binkowski•1,620
    @GrzywN

    Add no-cache, when using fetch. It doesn't work properly on Firefox. For example:

    const response = await fetch("https://api.adviceslip.com/advice", {
  cache: "no-cache",
});

    Have a nice day! 😄

    Marked as helpful
  • Karol Binkowski•1,620
    @GrzywN

    I can't access your repo ;(. It's probably still private

  • Karol Binkowski•1,620
    @GrzywN

    i love it, great job

View more comments