Responsive age calculator

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • The width: 100vw property for body element is not necessary. because it's a block level element which will take the full width of the page by default.

  ---

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Light Yagami•90

  @rakibhossainrajuPosted over 1 year ago

  @0xAbdulKhalid Thanks a lot for your helpful suggestions ☺️

  0
• 

  _nehal💎•6,710

  @NehalSahu8055Posted over 1 year ago

  Hello Coder 👋.

  Congratulations on successfully completing the challenge! 🎉

  Few suggestions regarding design.

  • Remove commented line from the code and replace height with min-height for proper centering the card.

  body {
  display: flex;
  justify-content: center;
  align-items: center;
  min-height: 100vh;
  /* width: 100vw; */
  /* overflow: hidden; */ cause not able to scroll.
  }
  

  ➨Setting an element's width to 100vw makes it as wide as the current viewport. But doing that is bad practice. First, it is almost always unnecessary. A block element, by default, already takes up all the available width. Setting the width manually is not needed in that situation.

  ➨ You can use accessibility features like aria, sr-only, and title which are accessible to screen readers.

  I hope you find this helpful.

  Happy coding😄

  Marked as helpful

  1

  ---

  

  Light Yagami•90

  @rakibhossainrajuPosted over 1 year ago

  @NehalSahu8055 I implemented the changes and it helped. Thank you for your constructive comment 😊☺️

  0
• 

  Karol Binkowski•1,640

  @GrzywNPosted over 1 year ago

  Hey Kira!

  Things worth considering:

  • Adding ESLint and Prettier to your project to make code practices and formatting consistent
  • Splitting big components into smaller ones
  • Extracting app logic into utils and hooks (like calculating relative dates etc.)

  Have a nice day and keep coding!

  1