Mobile first with React.js, Framer Motion and Tailwind CSS
Design comparison
Solution retrospective
This is my first project in React and I've learned a lot π The components may be too big and the code is not as clean as it could be, but I'm really happy with the final result, especially the animations. For the first time I used some other tools like Tailwind or Framer Motion and it was a pleasure. Any feedback is welcome here π.
Community feedback
- @ApplePieGiraffePosted over 2 years ago
Hi, Karol Binkowski! π
Good job on this challenge! π Your solution looks great and responds nicely! π I really like the animations that you added to the components, as well! π
A tiny suggestion I have is to wrap the meatballs menu icons in
button
tags since they would typically open some sort of menu when clicked.I took a look at your code and noticed that you were doing this in your components:
export default function Component(props) { const { prop1 } = props; const { prop2 } = props; const { prop3 } = props; // etc.
It's much easier (and nicer-looking, haha) to simply grab those props using object destructuring syntax, as in:
export default function Component({ prop1, prop2, prop3 }) { // etc.
You can then reference those props normally in the rest of your function. If you'd like to learn more about object destructuring/assignment, check out this helpful video on the topic.
Hope this helps. π
Keep coding (and happy coding, too)! π
Marked as helpful2@GrzywNPosted over 2 years ago@ApplePieGiraffe Now as I see it, it's funny to me (just like when I saw return
isValid() ? true : false
in my code π€£). I could have wrapped the props inconst { prop1, prop2, prop3 } = props
statement, but I didn't remember I could do that in function arguments directly (I think I've done it before). Thanks a lot and have a nice day π.1@ApplePieGiraffePosted over 2 years ago@GrzywN
Haha, glad to help! Have a nice day, too! βοΈ
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord