Skip to content
OverviewSolutions
17
Comments
2

Abed Fetrat

@abedfetratStockholm450 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

I’m currently learning...

Currently learning front-end development. I'm enrolled in Codecademy but before I proceed to Javascript and Frameworks I want to get comfortable with styling pages with CSS.

Latest solutions

View more solutions

Latest comments

  • Abed Fetrat•450
    @abedfetratPosted over 2 years ago

    It looks great! Especially the animations. I love how Commander Douglas on the Crew page shoots upwards 😄 Unfortunately I can't give much of a helpfull feedback as I haven't worked with React yet.

    1
  • Abed Fetrat•450
    @abedfetratPosted about 3 years ago

    Hey! Good job on this solution! Some minor things I would consider:

    • changing card__header--age to something more like card__header-age (with one dash) or card__age, because two dashes implies it is a modifier. BEM modifier should only be added to the block/element it modifies (eg. changing appearance, state or behaviour) while keeping the original class. The age span in this case is more like a element of the card block. Read more here

    • add a background color from the image on the card__head beacuse right now it goes from white to background because the image takes a bit to load. This will ease the shift a bit.

    • Use rem/em for the font sizes. I see that you already use em for paddings and margins :like:

    Other than that it looks great!

    Marked as helpful
    0