All comments

• 

  Janos Takacs•230

  @JT1974Submitted over 2 years ago

  

  Responsive multi-page site made with React & React Router

  #fetch#react#react-router#sass/scss#styled-components

  3

  50
  

  Abed Fetrat•450

  @abedfetratPosted over 2 years ago

  It looks great! Especially the animations. I love how Commander Douglas on the Crew page shoots upwards 😄 Unfortunately I can't give much of a helpfull feedback as I haven't worked with React yet.

  1
• 

  Karol Binkowski•1,640

  @GrzywNSubmitted about 3 years ago

  

  Profile card | SCSS, BEM and CSS animations.

  #bem#sass/scss

  2

  51
  

  Abed Fetrat•450

  @abedfetratPosted about 3 years ago

  Hey! Good job on this solution! Some minor things I would consider:

  • changing card__header--age to something more like card__header-age (with one dash) or card__age, because two dashes implies it is a modifier. BEM modifier should only be added to the block/element it modifies (eg. changing appearance, state or behaviour) while keeping the original class. The age span in this case is more like a element of the card block. Read more here

  • add a background color from the image on the card__head beacuse right now it goes from white to background because the image takes a bit to load. This will ease the shift a bit.

  • Use rem/em for the font sizes. I see that you already use em for paddings and margins :like:

  Other than that it looks great!

  Marked as helpful

  0