Tried experimenting many things through this project, the font color gave me a tough time also the border-bottom which seems to be hardly visible in the design. Still feels like there's something odd with the background. If anyone feels the same please hail me with suggestions.
James Gascoigne
@Gascoigne09All comments
- @saurabh1996-rexSubmitted over 3 years ago@Gascoigne09Posted over 3 years ago
that something odd in the background might be the two circles being in the wrong places maybe?
0 - @Bijay4444Submitted over 3 years ago
I would really appreciate the feedback. The one that I received before helped to explore how to host my site on GitHub with branches. So it would really help me. Thank you.
@Gascoigne09Posted over 3 years agoGreat job dude, I found your code so much easier to read than my own hahaha.
1 - @codingkapurSubmitted over 3 years ago
Would it be possible to achieve responsiveness with this kind of a layout without a media query, with just Grid?
@Gascoigne09Posted over 3 years agoIf it were possible, i would image it to be a lot more annoying to put in place than using media queries.
Also, you might want to have a look at using a max-width on your cards at larger screen sizes as they become quite stretched.
Great job though
0 - @TdZinkSubmitted over 3 years ago
This is my first challenge. My goal was to be able to complete it with what I know. There are a number of things I could of done better and already recognized a few things I will change when I tackle the next challenge.
Would specifically like feedback around getting my main card container to stay center as the screen size changes. It does not have additional responsiveness items such as clamp or min/max but would like to at least have it stay centered.
@Gascoigne09Posted over 3 years agoBy the looks of it you've tried to use transform to centre your container. You'd need to include this i believe:
position: absolute; top: 50%; left: 50% transform: translate(-50%, -50%);
2 - @vanzasetiaSubmitted over 3 years ago
Hello Everyone! 👋
I was doing this challenge on my Android phone. Hopefully, it looks good on your deskop. 😅
Of course, any feedback is appreciated!
That's it! Happy coding everyone!
@Gascoigne09Posted over 3 years agoThis is an incredible effort if its something you've done on your phone.
There is one small detail I'd like to address, when the viewport hits its breakpoint, your karma and team builder containers are slightly smaller than the ones on left and the right, but as the viewport increases the problem is very quickly resolved.
It's a tiny detail i'm bringing up but again shows you've done a great job. :)
1 - @JaredBrown1Submitted over 3 years ago
I feel like I could have wrote my css more dry but it gets overwhelming the more things that need styling.
@Gascoigne09Posted over 3 years agoOne of the easiest ways to help with the feeling of being overwhelmed is to spend just that little extra time thinking about what classnames you can use and really set each section apart from each other.
I see a lot of .card-this and .card-that and it would eventually start giving me a headache when i needed to make the minor finishing touches. Comments are great to, i use them to break my work up.
Finally have you considered building projects with mobile first in mind? It'll save you time and another headache!
0 - @danieljacquinSubmitted over 3 years ago
This is my first challenge here any feedback is appreciated
@Gascoigne09Posted over 3 years agoHave you considered using max-width on your containers to avoid them stretching out significantly before reaching your break point?
0 - @Gascoigne09Submitted over 3 years ago
Feel free to critique what i've done. From the smallest thing you would change or if you'd do it a completely different way, share your work with me?
Let's have a chat.
Been trying to learn on my own for a few months, so having a conversation with anyone about it would be nice.
Bye for now!
@Gascoigne09Posted over 3 years agoIve just realised my code review link goes to an incorrect place!
https://github.com/Gascoigne09/3-Column-Preview-Card.git
0