Hi,
I'm not sure why the project has such a complex set up? You are calling render blocking js in the document head, which doesn't seem to be being used. I recommend you remove that.
I also think you should take another pass at this challenge tbh. There is a quite a lot of learning points that need addressing before moving on.
On mobile for me, things are not positioned right and there is loads of scroll in all directions
I suggest
- remove excessive divs in the html that aren't needed for this layout
- semantic html - use meaningful elements for the stats. Numbers don't make sense as headings, and they need to be in the same meaningful element as the word that follows them
- use css to capitalise text, don't write it like that in html
- remove all position absolutes and transforms. Create the layout with flexbox. You'll find it easiest if you style mobile first
- remove large paddings and margins
- change units in css - font sizes must never be in px, use rem/em; line-height should be unitless like 1.5;
- remove all the widths and heights. You won't need almost all of them. Just a max-width on the card, min-height on the image, maybe flex-basis 50% on desktop.
- remove visibility hidden from attribution
I hope these suggestions help your learning
@TdZink
Posted
@grace-snow I appreciate your feedback. This will help when I take another pass at it.
In regards to the font size should you still set the main font-size provided by the guide in px then use rem/em for any changes away from the base?
@TdZink
Posted
@grace-snow I published a new solution being able to address some of the issues you pointed out. I have not yet been able to figure out how to remove all the widths and heights thought I did reduce how many I am using. Same with the paddings and margins.
@TdZink no, font sizes should never be in px. You can change the html/root size with percentages but I wouldn't recommend that either. People with different zoom settings or visual impairments need the root size to be left alone and sizes in rem/em so it scales correctly for them.
I use a scss function to change px to rem and use it all over the place. It's just pixel-size-you-want / 16 so is pretty straightforward