Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

html,css,flexbox

@danieljacquin

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is my first challenge here any feedback is appreciated

Community feedback

P
tediko 6,680

@tediko

Posted

Hello, Daniel Jacquin! 👋

Congrats on finishing your first challenge! Your solution looks very good and also responds well. Here's my few tips:

  • Change the alt attributes for the .card__icon-wrap icons, as they don't add any extra context for screen reader users. Since your images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.

Good luck with that, have fun coding! 💪

0

@danieljacquin

Posted

@tediko I changed alt attributes for the .card__icon-wrap icons, thanks for tips. i appreciated it.

0

@Gascoigne09

Posted

Have you considered using max-width on your containers to avoid them stretching out significantly before reaching your break point?

0

@danieljacquin

Posted

@Gascoigne09 i put a max-width to the card and looks like better now. thanks for your comment

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord