html,css,flexbox

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Daniel Jacquin! 👋

  Congrats on finishing your first challenge! Your solution looks very good and also responds well. Here's my few tips:

  • Change the alt attributes for the .card__icon-wrap icons, as they don't add any extra context for screen reader users. Since your images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.

  Good luck with that, have fun coding! 💪

  0

  ---

  

  daniel jacquin•10

  @danieljacquinPosted over 3 years ago

  @tediko I changed alt attributes for the .card__icon-wrap icons, thanks for tips. i appreciated it.

  0
• 

  James Gascoigne•130

  @Gascoigne09Posted over 3 years ago

  Have you considered using max-width on your containers to avoid them stretching out significantly before reaching your break point?

  0

  ---

  

  daniel jacquin•10

  @danieljacquinPosted over 3 years ago

  @Gascoigne09 i put a max-width to the card and looks like better now. thanks for your comment

  0