P
Shayne Wuver• 40
@WindowsM16a
Submitted
What specific areas of your project would you like help with?
I'm having issues with the alignment of the nutritional values, if anyone could help, that'd be wonderful.
Djamel1133
@Djamel1133
All comments
- Djamel1133• 150
@Djamel1133
Posted
Hi, Great job ! I am not expert but i suggest little thing to improve your project:
-
Since you have used Flexbox in your container you could simplify your code by removing it from main and body section (container hold all elemnts).
-
it is recommended using a modern CSS reset at the start of your styles in every project. It helps reset a list of default browser styles, ensuring consistency across different browsers (https://piccalil.li/blog/a-more-modern-css-reset/).
I hope these suggestions are helpful. Happy onding !
0 -
- Hossein-H-I• 30
@Hossein-H-I
Submitted
Djamel1133• 150@Djamel1133
Posted
Hi, Great job on your work! I have a few suggestions that might help improve your project:
-
Use of Flexbox in the Body Section: I noticed that you are using Flexbox in your body section. Since Flexbox is already used in avatar.container, you might not see much benefit in having it in the body section as well. It could simplify your code if you remove the redundant Flexbox implementation.
-
Media Queries: Given that you are using rem units and min-width in your container, you might not need all the media queries you've implemented. You could try removing some of them and see if it affects your layout, as the flexible units might already be handling the responsiveness well.
-
Modern CSS Reset: I recommend using a modern CSS reset at the start of your styles in every project. It helps reset a list of default browser styles, ensuring consistency across different browsers.
I hope these suggestions are helpful.
Marked as helpful
0 -
- mohamed-m-atef• 30
@mohamed-m-atef
Submitted
Djamel1133• 150@Djamel1133
Posted
Hi, I'm not an expert, but I noticed a few points that might help improve your code:
Your main div doesn't contain all your elements because you fixed the height at 70%. I suggest removing this height restriction. You can remove the profileimg div and keep only your image with the class img.
For height and width properties, it's preferred to use em or rem units, like this: height: value in rem; width: value in rem; for more details see : Why font-size must NEVER be in pixels.
To get a full page without scrolling, you can set the dimensions of your main div as follows: height: 100vh; width: 100vw; (but not in the body)
You should use .buttonlink:hover instead of .buttonlink:active. Good job and keep it up!
0 - Djamel1133• 150
@Djamel1133
Submitted
Djamel1133• 150@Djamel1133
Posted
I have fixed the issues you pointed out. Regarding the use of "inherit," I did it intentionally so that the image's radius follows the same style as the global container. Thanks, it was very helpful.
0 - Romaissa Zaoui• 450
@Romaissazr
Submitted
Djamel1133• 150@Djamel1133
Posted
How can you do it so fast!!! please what is your trick ? method ? Thank you
0 - Zxjklp• 40
@Zxjklp
Submitted
Djamel1133• 150@Djamel1133
Posted
Hi, well done I am not expert but i think a lot of things must go to reset.css file : /* Remove list styles on ul, ol elements with a list role, which suggests default styling will be removed */ ul[role="list"], ol[role="list"] { list-style: none; } Thank you.
0 - Kiran Manoj• 10
@KiranManoj
Submitted
What are you most proud of, and what would you do differently next time?
I came to know about favicons and the usage of flex.
What challenges did you encounter, and how did you overcome them?
I faced issues while doing GIT and had to search in Stack Overflow to get over it.
What specific areas of your project would you like help with?
How to add Tailwind CSS to apply responsiveness to it.
Djamel1133• 150@Djamel1133
Posted
Hi, well done... I am not expert but i think it is better to removed duplicate height: 100% from html, body since height: 100vh is already set in body and remove some unused properties like width: 100% in main (it is unnecessary since it will naturally take the full width of its parent). you can (for this chalenge) justify your content like this : main{ height: 100vh; align-content: center; /* just this to center your content ...... } Again great job ...keep trying.
0 - Djamel1133• 150
@Djamel1133
Submitted
What are you most proud of, and what would you do differently next time?
I’m happy to have completed this challenge by creating versions that are nearly identical to the original for desktop, tablet, and mobile. I also honed my skills in manipulating tables using pseudo-classes like
:last-childand:nth-child. Additionally, I’m pleased with the customization I achieved for unordered (ul) and ordered (ol) lists.What challenges did you encounter, and how did you overcome them?
A lot of customization, including lists, tables, and handling different values for various selectors, is needed to achieve a responsive design. I think a moment of hindsight is necessary at this stage to see how I can move forward and improve.
What specific areas of your project would you like help with?
idea and principles of responsive design and a methodology to work with (mobile first principle, best practice, ...etc.)
Djamel1133• 150@Djamel1133
Posted
i commited a new css file with some optimizations in the aim to make it more readable and maintainable. thanks to all.
0 - Djamel1133• 150
@Djamel1133
Submitted
What are you most proud of, and what would you do differently next time?
graphics and look
Djamel1133• 150@Djamel1133
Posted
Thank you it was helpfull.
0
