@Crtykwod
@david-franca
Submitted
What are you most proud of, and what would you do differently next time?
Im learn houw to use responsive images.
What challenges did you encounter, and how did you overcome them?
Make page responsive with two images in one card.
What specific areas of your project would you like help with?
Im fine
@Crtykwod
Posted
Olá, meu mano David, tudo bem? Olha, eu não sou lá aquele desenvolvedores front-end, mas há alguns pontos que pessoas mais experientes já corrigiram em meus códigos e espero que lhe venha a calhar.
<h4>, lembre-se sempre de respeitar a hierarquia de título, você não pode inseri-lo sem antes ter um <h3> presente no documento e nem o <h3> antes de ter um <h2>. Existem exceções, mas por via de regra, siga a ordem.<footer> está sobrepondo seu .card, não use position: absolute;, ao invés disso, prefira algo como:body {
display: grid;
grid-template-rows: 1fr 2em;
}
Assim, seu footer terá um espaço de 2em no final da página, não interferindo nos outros elementos.
No mais, foi isso que percebi, espero te ajudar de alguma forma e pode ter certeza que o código está muito bem estruturado em sua maioria. Parabéns!!
@Makc240305
Submitted
@Crtykwod
Posted
Hiii! You made a great job completing this challenge, and I hope you can make useful observations in your project!
The aside tag is not correct in this context. It must be used to define content that is indirectly related to the main content. Preparation time is directly related to the recipe.
font-size should always be in rem to garant accessibility. People who need to use bigger font-sizes will see no difference in you website because the font size used is fixed to a unique value.
@Mahi-54
Submitted
What are you most proud of, and what would you do differently next time?
What challenges did you encounter, and how did you overcome them?
@Crtykwod
Posted
Hello!! I'm not an expert, but I hope I can help you fix some errors:
Firstly, the button should only turn green when the mouse hovers over it
HTML:
alt="" in the <img>. This is fundamental for accessibility.<div>s, you should use semantic tags like <main>, <section>, <header>...CSS:
<link> in <head> instead of @import to get the font, this will give a slight performance boost.height: 100vh on the body, prefer min-height: 100vh. It will sound like "Use height of at least 100vh", which ensures more compatibility.That's what I noticed, I hope it helps in some way! <3
@sepehrsylvanus
Submitted
@Crtykwod
Posted
You should consider putting your <div class="atribution"> as a <footer> instead of <div> to make it more semantic.
Put the transition in the .title class, not in the .tile:hover pseudoclass. Doing that you also have a smooth transition when the mouse stops hovering the title.
@JEJS-IA97
Submitted
@Crtykwod
Posted
You uploaded the wrong solution to this challenge, didn't you?
