Skip to content
OverviewSolutions
12
Comments
29
Boluwatife Bonaventure
@Boyutife

All comments

  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi Cesar Perez​ 👋. Congratulations on successfully completing the challenge! 🎉

    HTML:🔖🔖

    • Great job on using the p tag in your content! I wanted to offer a suggestion that could help improve the accessibility of your page. Currently, it looks like you have p tag in your content, but it might be more helpful to use an h1 tag instead. This is because using an h1 tag as the main heading on your page can improve accessibility and make it easier for users to navigate your content.

    • In general, it's a good idea to use only one h1 tag on each page, followed by h2 and h3 tags to organize your content. This will not only help with accessibility, but also make it easier for search engines to understand the structure of your page.

    • So, my suggestion is to consider using an h1 tag as your main heading, followed by h2 and h3 tags as needed to organize your content. This will help improve the accessibility and usability of your page for all users.

    • Also, instead of using a div tag to wrap your content, you might consider using a main tag, which is more semantically appropriate for indicating the primary content of your webpage

     <main class="main-container">
    <div class="qr-container">
      <img src="./images/image-qr-code.png" alt="QR-code-image">
      <div class="content">
        <h1>Improve your front-end skills by building projects</h1>
        
        <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
      </div>
    </div>
  </main>

    STYLE: 🎨🎨

    You considering using relative units like em and rem rather than fixed units like px for your styling because of the following :

    • Accessibility: Using relative units can improve accessibility for users who may need to increase the font size or zoom in on a web page. With relative units, the font and layout will adjust accordingly, making it easier for users to read and interact with the content.

    • Responsive design: Relative units can also make your design more responsive, as they allow your layout to adapt to different screen sizes and device types. This can be especially important for mobile devices, where screen sizes can vary significantly.

    • Consistency: Relative units can help maintain consistency across your design, as they ensure that fonts and layout elements are sized in proportion to each other. This can make your design look more polished and professional.

    • Scalability: Finally, using relative units can make your code more scalable and easier to maintain, as changes to font or layout sizes can be made in one place and affect the entire design.

    • In conclusion, to make your design more centralized and compact, you might consider setting a max-height and max-width property for your main container. This can help ensure that your content is displayed in a consistent and visually appealing manner, especially on smaller screens.

    I hope these suggestions are helpful and will lead to an even better final product. Let me know if you have any further questions or need additional assistance!

    HAPPY CODING

    Marked as helpful
    1
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi roger-hope​ 👋. Congratulations on successfully completing the challenge! 🎉

    HTML:🔖🔖

    • Great job on using the h3 tag in your content! I wanted to offer a suggestion that could help improve the accessibility of your page. Currently, it looks like you have h3 tag in your content, but it might be more helpful to users if you use an h1 tag instead. This is because using an h1 tag as the main heading on your page can improve accessibility and make it easier for users to navigate your content.

    • In general, it's a good idea to use only one h1 tag on each page, followed by h2 and h3 tags to organize your content. This will not only help with accessibility, but also make it easier for search engines to understand the structure of your page.

    • So, my suggestion is to consider using an h1 tag as your main heading, followed by h2 and h3 tags as needed to organize your content. This will help improve the accessibility and usability of your page for all users.

    • Also, instead of using a div tag to wrap your content, you might consider using a main tag, which is more semantically appropriate for indicating the primary content of your webpage

     <main class="card">
      <img src="images/image-qr-code.png" alt="qr-code-image">
      <h1>Improve your front-end skills by building projects</h1>
       <p> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    </main>
    • In conclusion, to make your design more centralized and compact, you might consider setting a max-height and max-width property for your main container. This can help ensure that your content is displayed in a consistent and visually appealing manner, especially on smaller screens.

    I hope these suggestions are helpful and will lead to an even better final product. Let me know if you have any further questions or need additional assistance!

    HAPPY CODING

    0
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi Ahmet Furkan Meriç​ 👋. Congratulations on successfully completing the challenge! 🎉

    Great Job

    HTML:🔖🔖

    • Great job on using the h3 tag in your content! I wanted to offer a suggestion that could help improve the accessibility of your page. Currently, it looks like you have h3 tag in your content, but it might be more helpful to users if you use an h1 tag instead. This is because using an h1 tag as the main heading on your page can improve accessibility and make it easier for users to navigate your content.

    • In general, it's a good idea to use only one h1 tag on each page, followed by h2 and h3 tags to organize your content. This will not only help with accessibility, but also make it easier for search engines to understand the structure of your page.

    • So, my suggestion is to consider using an h1 tag as your main heading, followed by h2 and h3 tags as needed to organize your content. This will help improve the accessibility and usability of your page for all users.

    • Also, instead of using a div tag to wrap your content, you might consider using a main tag, which is more semantically appropriate for indicating the primary content of your webpage

     <main class="card">
      <img src="images/image-qr-code.png" alt="qr-code-image">
      <h1>Improve your front-end skills by building projects</h1>
       <p> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    </main>

    STYLE: 🎨🎨

    You considering using relative units like em and rem rather than fixed units like px for your styling because of the following :

    • Accessibility: Using relative units can improve accessibility for users who may need to increase the font size or zoom in on a web page. With relative units, the font and layout will adjust accordingly, making it easier for users to read and interact with the content.

    • Responsive design: Relative units can also make your design more responsive, as they allow your layout to adapt to different screen sizes and device types. This can be especially important for mobile devices, where screen sizes can vary significantly.

    • Consistency: Relative units can help maintain consistency across your design, as they ensure that fonts and layout elements are sized in proportion to each other. This can make your design look more polished and professional.

    • Scalability: Finally, using relative units can make your code more scalable and easier to maintain, as changes to font or layout sizes can be made in one place and affect the entire design.

    • In conclusion, to make your design more centralized and compact, you might consider setting a max-height and max-width property for your main container. This can help ensure that your content is displayed in a consistent and visually appealing manner, especially on smaller screens.

    I hope these suggestions are helpful and will lead to an even better final product. Let me know if you have any further questions or need additional assistance!

    HAPPY CODING

    0
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi Stano​ 👋. Congratulations on successfully completing the challenge! 🎉

    HTML:🔖🔖

    • Great job on using the h1 tag in your content! I wanted to offer a suggestion that could help improve the accessibility of your page. Currently, it looks like you have multiple h1 tags in your content, but it might be more helpful to users if you use only an h1 tag instead. This is because using an h1 tag as the main heading on your page can improve accessibility and make it easier for users to navigate your content.

    • In general, it's a good idea to use only one h1 tag on each page, followed by h2 and h3 tags to organize your content. This will not only help with accessibility, but also make it easier for search engines to understand the structure of your page.

    • So, my suggestion is to consider using an h1 tag as your main heading, followed by h2 and h3 tags as needed to organize your content. This will help improve the accessibility and usability of your page for all users.

    I hope these suggestions are helpful and will lead to an even better final product. Let me know if you have any further questions or need additional assistance!

    HAPPY CODING

    Marked as helpful
    0
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi OKORIE OKORO MERCY​ 👋. Congratulations on successfully completing the challenge! 🎉

    HTML:🔖🔖

    • Great job on using the h5 tag in your content! I wanted to offer a suggestion that could help improve the accessibility of your page. Currently, it looks like you have h5 tag in your content, but it might be more helpful to users if you use an h1 tag instead. This is because using an h1 tag as the main heading on your page can improve accessibility and make it easier for users to navigate your content.

    • In general, it's a good idea to use only one h1 tag on each page, followed by h2 and h3 tags to organize your content. This will not only help with accessibility, but also make it easier for search engines to understand the structure of your page.

    • So, my suggestion is to consider using an h1 tag as your main heading, followed by h2 and h3 tags as needed to organize your content. This will help improve the accessibility and usability of your page for all users.

    • Also, instead of using a div tag to wrap your content, you might consider using a main tag, which is more semantically appropriate for indicating the primary content of your webpage

     <main class="page">
      <img src="images/image-qr-code.png" alt="qr-code-image">
      <h1>Improve your front-end skills by building projects</h1>
       <p> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    </main>

    STYLE: 🎨🎨

    You considering using relative units like em and rem rather than fixed units like px for your styling because of the following :

    • Accessibility: Using relative units can improve accessibility for users who may need to increase the font size or zoom in on a web page. With relative units, the font and layout will adjust accordingly, making it easier for users to read and interact with the content.

    • Responsive design: Relative units can also make your design more responsive, as they allow your layout to adapt to different screen sizes and device types. This can be especially important for mobile devices, where screen sizes can vary significantly.

    • Consistency: Relative units can help maintain consistency across your design, as they ensure that fonts and layout elements are sized in proportion to each other. This can make your design look more polished and professional.

    • Scalability: Finally, using relative units can make your code more scalable and easier to maintain, as changes to font or layout sizes can be made in one place and affect the entire design.

    • In conclusion, to make your design more centralized and compact, you might consider setting a max-height and max-width property for your main container. This can help ensure that your content is displayed in a consistent and visually appealing manner, especially on smaller screens.

    I hope these suggestions are helpful and will lead to an even better final product. Let me know if you have any further questions or need additional assistance!

    HAPPY CODING

    0
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi KISHOR JHA​ 👋. Congratulations on successfully completing the challenge! 🎉

    HTML:🔖🔖

    • Great job on using the h3 tag in your content! I wanted to offer a suggestion that could help improve the accessibility of your page. Currently, it looks like you have h3 tag in your content, but it might be more helpful to users if you use an h1 tag instead. This is because using an h1 tag as the main heading on your page can improve accessibility and make it easier for users to navigate your content.

    • In general, it's a good idea to use only one h1 tag on each page, followed by h2 and h3 tags to organize your content. This will not only help with accessibility, but also make it easier for search engines to understand the structure of your page.

    • So, my suggestion is to consider using an h1 tag as your main heading, followed by h2 and h3 tags as needed to organize your content. This will help improve the accessibility and usability of your page for all users.

    • Also, instead of using a div tag to wrap your content, you might consider using a main tag, which is more semantically appropriate for indicating the primary content of your webpage

     <main class="card">
      <img src="images/image-qr-code.png" alt="qr-code-image">
      <h1>Improve your front-end skills by building projects</h1>
       <p> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    </main>

    STYLE: 🎨🎨

    You considering using relative units like em and rem rather than fixed units like px for your styling because of the following :

    • Accessibility: Using relative units can improve accessibility for users who may need to increase the font size or zoom in on a web page. With relative units, the font and layout will adjust accordingly, making it easier for users to read and interact with the content.

    • Responsive design: Relative units can also make your design more responsive, as they allow your layout to adapt to different screen sizes and device types. This can be especially important for mobile devices, where screen sizes can vary significantly.

    • Consistency: Relative units can help maintain consistency across your design, as they ensure that fonts and layout elements are sized in proportion to each other. This can make your design look more polished and professional.

    • Scalability: Finally, using relative units can make your code more scalable and easier to maintain, as changes to font or layout sizes can be made in one place and affect the entire design.

    • In conclusion, to make your design more centralized and compact, you might consider setting a max-height and max-width property for your main container. This can help ensure that your content is displayed in a consistent and visually appealing manner, especially on smaller screens.

    I hope these suggestions are helpful and will lead to an even better final product. Let me know if you have any further questions or need additional assistance!

    HAPPY CODING

    0
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi Hassan 👋. Congratulations on successfully completing the challenge! 🎉

    Great work on your markup so far! I have few suggestions that could further improve the structure and design of your webpage.

    HTML:🔖🔖

    • Instead of using a div tag to wrap your content, you might consider using a main tag, which is more semantically appropriate for indicating the primary content of your webpage.

    • In conclusion, to make your design more centralized and compact, you might consider setting a max-height and max-width property for your main container. This can help ensure that your content is displayed in a consistent and visually appealing manner, especially on smaller screens.

    I hope these suggestions are helpful and will lead to an even better final product. Let me know if you have any further questions or need additional assistance!

    HAPPY CODING

    Marked as helpful
    1
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi Nattha​ Wanaemi Immanuella 👋. Congratulations on successfully completing the challenge! 🎉

    Great work on your markup so far! I have few suggestions that could further improve the structure and design of your webpage.

    HTML:🔖🔖

    • Instead of using a div tag to wrap your content, you might consider using a main tag, which is more semantically appropriate for indicating the primary content of your webpage.

    STYLE: 🎨🎨

    You considering using relative units like em and rem rather than fixed units like px for your styling because of the following :

    • Accessibility: Using relative units can improve accessibility for users who may need to increase the font size or zoom in on a web page. With relative units, the font and layout will adjust accordingly, making it easier for users to read and interact with the content.

    • Responsive design: Relative units can also make your design more responsive, as they allow your layout to adapt to different screen sizes and device types. This can be especially important for mobile devices, where screen sizes can vary significantly.

    • Consistency: Relative units can help maintain consistency across your design, as they ensure that fonts and layout elements are sized in proportion to each other. This can make your design look more polished and professional.

    • Scalability: Finally, using relative units can make your code more scalable and easier to maintain, as changes to font or layout sizes can be made in one place and affect the entire design.

    I hope these suggestions are helpful and will lead to an even better final product. Let me know if you have any further questions or need additional assistance!

    HAPPY CODING

    0
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi ​DANIEL MURI 👋. Congratulations on successfully completing the challenge! 🎉

    Great work on your markup so far! I have few suggestions that could further improve the structure and design of your webpage.

    HTML:🔖🔖🔖

    • Also, instead of using a div tag to wrap your content, you might consider using a main tag, which is more semantically appropriate for indicating the primary content of your webpage. In conclusion, to make your design more centralized and compact, you might consider setting a max-height and max-width property for your main container. This can help ensure that your content is displayed in a consistent and visually appealing manner, especially on smaller screens.

    STYLE: 🎨🎨

    You considering using relative units like em and rem rather than fixed units like px for your styling because of the following :

    • Accessibility: Using relative units can improve accessibility for users who may need to increase the font size or zoom in on a web page. With relative units, the font and layout will adjust accordingly, making it easier for users to read and interact with the content. Responsive design: Relative units can also make your design more responsive, as they allow your layout to adapt to different screen sizes and device types. This can be especially important for mobile devices, where screen sizes can vary significantly.

    • Consistency: Relative units can help maintain consistency across your design, as they ensure that fonts and layout elements are sized in proportion to each other. This can make your design look more polished and professional.

    • Scalability: Finally, using relative units can make your code more scalable and easier to maintain, as changes to font or layout sizes can be made in one place and affect the entire design.

    I hope these suggestions are helpful and will lead to an even better final product. Let me know if you have any further questions or need additional assistance!

    HAPPY CODING

    0
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi ​Chibuzor victor 👋. Congratulations on successfully completing the challenge! 🎉

    Great work on your markup so far! I have few suggestions that could further improve the structure and design of your webpage.

    HTML:🔖🔖🔖

    • Great job on using the h3 tag in your content! I wanted to offer a suggestion that could help improve the accessibility of your page.

    • My suggestion is to consider using an h1 tag as your main heading, followed by h2 and h3 tags as needed to organize your content. This will help improve the accessibility and usability of your page for all users.In general, it's a good idea to use only one h1 tag on each page, followed by h2 and h3 tags to organize your content. This is because using an h1 tag as the main heading on your page can improve accessibility and make it easier for users to navigate your content.

    • This will not only help with accessibility, but also make it easier for search engines to understand the structure of your page.

    • Also, instead of using a div tag to wrap your content, you might consider using a main tag, which is more semantically appropriate for indicating the primary content of your webpage. In conclusion, to make your design more centralized and compact, you might consider setting a max-height and max-width property for your main container. This can help ensure that your content is displayed in a consistent and visually appealing manner, especially on smaller screens.

    STYLE: 🎨🎨

    You considering using relative units like em and rem rather than fixed units like px for your styling because of the following :

    • Accessibility: Using relative units can improve accessibility for users who may need to increase the font size or zoom in on a web page. With relative units, the font and layout will adjust accordingly, making it easier for users to read and interact with the content. Responsive design: Relative units can also make your design more responsive, as they allow your layout to adapt to different screen sizes and device types. This can be especially important for mobile devices, where screen sizes can vary significantly.

    • Consistency: Relative units can help maintain consistency across your design, as they ensure that fonts and layout elements are sized in proportion to each other. This can make your design look more polished and professional. Scalability: Finally, using relative units can make your code more scalable and easier to maintain, as changes to font or layout sizes can be made in one place and affect the entire design.

    I hope these suggestions are helpful and will lead to an even better final product. Let me know if you have any further questions or need additional assistance!

    HAPPY CODING

    Marked as helpful
    0
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi Nattha​ Potchanad​ 👋. Congratulations on successfully completing the challenge! 🎉

    Great work on your markup so far! I have few suggestions that could further improve the structure and design of your webpage.

    HTML:🔖🔖

    I noticed you wrapped your entire content in a div. Instead of using a div tag to wrap your content, you might consider using a main tag, which is more semantically appropriate for indicating the primary content of your webpage.

    Just a quick observation: it's important to include heading tags (<h1>, <h2>, etc.) in your content. According to standard web design practices, an <h1> tag should be used at the beginning, followed by the <h2> tag, and so on. This means you can't use an <h3> tag without first including an <h1> and <h2>. Headings are important for organizing your content and making it more accessible to users, so be sure to include them in your webpage.

    <div class="summary-box-con">

    Another suggestion I have is to consider using a <ul> tag for the elements you currently have with identical properties. This can be helpful in creating a more responsive design, and could also result in a reduction in the amount of CSS required. By using children and type selectors in your CSS, you can target each element without needing to add a class attribute to them in your HTML. This can make your code more streamlined and easier to maintain in the long run.

    STYLE: 🎨🎨

    You considering using relative units like em and rem rather than fixed units like px for your styling because of the following :

    -Accessibility: Using relative units can improve accessibility for users who may need to increase the font size or zoom in on a web page. With relative units, the font and layout will adjust accordingly, making it easier for users to read and interact with the content.

    -Responsive design: Relative units can also make your design more responsive, as they allow your layout to adapt to different screen sizes and device types. This can be especially important for mobile devices, where screen sizes can vary significantly.

    -Consistency: Relative units can help maintain consistency across your design, as they ensure that fonts and layout elements are sized in proportion to each other. This can make your design look more polished and professional.

    -Scalability: Finally, using relative units can make your code more scalable and easier to maintain, as changes to font or layout sizes can be made in one place and affect the entire design.

    In conclusion, to make your design more centralized and compact, you might consider setting a max-height and max-width property for your main container. This can help ensure that your content is displayed in a consistent and visually appealing manner, especially on smaller screens.

    I hope these suggestions are helpful and will lead to an even better final product. Let me know if you have any further questions or need additional assistance!

    HAPPY CODING

    Marked as helpful
    0
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi Nattha​ Potchanad​ 👋. Congratulations on successfully completing the challenge! 🎉

    Great work on your markup so far! I have few suggestions that could further improve the structure and design of your webpage.

    STYLE: 🎨🎨

    You considering using relative units like em and rem rather than fixed units like px for your styling because of the following :

    • Accessibility: Using relative units can improve accessibility for users who may need to increase the font size or zoom in on a web page. With relative units, the font and layout will adjust accordingly, making it easier for users to read and interact with the content.

    • Responsive design: Relative units can also make your design more responsive, as they allow your layout to adapt to different screen sizes and device types. This can be especially important for mobile devices, where screen sizes can vary significantly.

    • Consistency: Relative units can help maintain consistency across your design, as they ensure that fonts and layout elements are sized in proportion to each other. This can make your design look more polished and professional.

    • Scalability: Finally, using relative units can make your code more scalable and easier to maintain, as changes to font or layout sizes can be made in one place and affect the entire design.

    Also, instead of using a div tag to wrap your content, you might consider using a main tag, which is more semantically appropriate for indicating the primary content of your webpage.

    In conclusion, to make your design more centralized and compact, you might consider setting a max-height and max-width property for your main container. This can help ensure that your content is displayed in a consistent and visually appealing manner, especially on smaller screens.

    I hope these suggestions are helpful and will lead to an even better final product. Let me know if you have any further questions or need additional assistance!

    HAPPY CODING

    0
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi SIRGRA 👋. Congratulations on successfully completing the challenge! 🎉 Job well done.

    HTML:🔖🔖

    I noticed that you used a div tag to wrap your content, which is a common practice. However, I recommend using a main tag instead as it is more semantically appropriate for wrapping the main content of a web page.

    By using a main tag, you can convey to search engines and assistive technologies that this is the primary content of the page, which can help with accessibility and search engine optimization.

    Overall, great job on your markup, and I hope this feedback is helpful in improving your web development skills.

    <main class="parent-container">

</main>

    Hope am helpful.

    HAPPY CODING

    Marked as helpful
    1
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi Dani 👋. Congratulations on successfully completing the challenge! 🎉

    Job well done.

    HTML: 🔖🔖🔖

    You might want to wrap the entire content in a main tag due to semantic structure

     <main class="qr-div">

    </main>

    CSS:🎨🎨

    I recommend you use relative units. Relative units adjust to the font-size of the parent element, making your design more flexible and responsive to different screen sizes and resolutions. On the other hand, px units are absolute and do not adjust based on the parent element, which can lead to inconsistent sizing and spacing across devices.

    To improve your use of relative units, I recommend using rem units for font-size values and em units for padding, margin, and width values. Rem units are relative to the root element, while em units are relative to the font-size of the parent element.

    .qr-div {
  background-color: hsl(0, 0%, 100%);
  width: 30%;
  margin: 10% auto;
  display: flex;
  justify-content: center;
  align-items: center;
  padding: 20px;
  border-radius: 5%;
}

    • Changed align-content to align-items to vertically center the content within the container.

    • Changed auto 10% auto 10% to 10% auto for a simpler shorthand for vertical and horizontal margin.

    • Added display: flex and justify-content: center to horizontally center the content within the container.

    • Removed the 20px 20px 20px 20px shorthand for padding and replaced it with 20px for simplicity.

    Hope am helpful.

    HAPPY CODING

    Marked as helpful
    0
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi HYEONJI SUNG 👋. Congratulations on successfully completing the challenge! 🎉

    Job well done.

    To improve your skills in grouping elements effectively, it's important to understand the differences between div and section elements. A div element is a generic container that can be used for any purpose, while a section element is used to group related content together. A section element should have a heading, such as an h1-h6 element, to describe the content it contains.

    In cases where you need to add a new div element and adjust the CSS to reposition elements, you might consider reviewing the layout of your page and determining if there is a more effective way to group the elements using div and section elements.

    I suggest practicing using div and section elements in different scenarios, and experimenting with different CSS properties to adjust the layout. You might also consider studying the layouts of other web pages to gain inspiration and learn new techniques.

    I have other suggestions:

    HTML: 🔖🔖

    You might want to wrap the entire content in a main tag.

    CSS: 🎨🎨

    I noticed that you used a lot of id selectors in your CSS file. While id selectors can be useful in certain situations, it's generally better to use more class and element selectors instead.

    Using class and element selectors allows for greater reusability of CSS styles across multiple elements on your web page. This can make it easier to maintain and update your styles in the long run.

    Additionally, I noticed that you used <b> tags to separate the number on your web page. Instead of using <b>, I recommend wrapping the number in a <span> tag and applying styles to the span element in your CSS file.

    Using a span element allows for greater control over the styling of the number, and separates it from the semantic meaning of the text. This can make it easier to update the styling of the number without affecting the meaning of the surrounding text.

    I hope this feedback is helpful to you. If you have any questions or need further clarification

    Hope am helpful.

    HAPPY CODING

    Marked as helpful
    1
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi Ilvis 👋. Congratulations on successfully completing the challenge! 🎉

    Job well done.

    The wv and hv units are relative to the viewport width and height, respectively. This means that they adjust automatically to the size of the user's screen, making your page more responsive and adaptable to different devices. For example, you could use "width: 50vw" to make an element take up 50% of the viewport width.

    I recommend reading the documentation on these units to get a better understanding of how they work and when they should be used. This will help you improve your skills in creating landing pages and static sites that are optimized for different devices.

    I have some additional suggestions for your code that I believe will be of great interest to you.

    CSS:🎨

    Use relative units like rem or em as the unit for the padding, margin, and width values, and preferably rem for the font-size values, instead of px, which is an absolute unit. This is a good practise when building a responsive page.

    HTML: 🔖

    I noticed that there is no h1 tag present on your web page. It's recommended to include an h1 tag for accessibility and search engine optimization purposes. Therefore, I suggest wrapping the main text in an h1 tag.

    Also, you might want to consider using the main tag instead of the section tag, since there is only one main content on the page. This will help improve the semantic structure of your HTML code.

    I hope this feedback is helpful to you. If you have any questions or need further clarification, please let me know.

    HAPPY CODING

    Marked as helpful
    1
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi Irmayanet85 👋. Congratulations on successfully completing the challenge! 🎉

    Job well done.

    I have some additional suggestions for your code that I believe will be of great interest to you.

    CSS:🎨🎨

    Use relative units like rem or em as the unit for the padding, margin, and width values, and preferably rem for the font-size values, instead of px, which is an absolute unit, for responsive content.

    Also you might want to flex the card_body class so that you can centralise the h1 and p tag and not have to use margin to centralise or you might just text-align:center.

    Hope am helpful.

    HAPPY CODING

    Marked as helpful
    0
  • Boluwatife Bonaventure•550
    @BoyutifePosted almost 2 years ago

    Hi Peter-Peter254 👋. Congratulations on successfully completing the challenge! 🎉

    Job well done .

    The font weight is good to go, the text-color you can be found in the style guard

    I have some additional suggestions for your code that I believe will be of great interest to you.

    HTML 🏷️:

    You consider using <main> tag for the <div> that wrap the whole content.

    I noticed you use <br> : you can flex the card class and then items-center and align-middle , then you wouldn't need the <br>

    <body class="flex items-center">
  <div class="mx-auto">
    *< Your centered content goes here >*
  </div>
</body>

    HEADINGS ⚠️:

    Heading tags (such as <h1>, <h2>, <h3>, etc.) are an important aspect of HTML markup, as they provide a hierarchical structure to the content on a webpage. you should use <h1> not <h2>, a landing page must have an <h1>. also you can't have h2 with having h1

    You can add a max-width to the card div

    I hope you find this helpful 😄 Above all, the solution you submitted is great ! Happy coding!

    0