Results summary component by Junsu

Community feedback

• 

  Boluwatife Bonaventure•550

  @BoyutifePosted over 1 year ago

  Hi Nattha​ Potchanad​ 👋. Congratulations on successfully completing the challenge! 🎉

  Great work on your markup so far! I have few suggestions that could further improve the structure and design of your webpage.

  HTML:🔖🔖

  I noticed you wrapped your entire content in a div. Instead of using a div tag to wrap your content, you might consider using a main tag, which is more semantically appropriate for indicating the primary content of your webpage.

  Just a quick observation: it's important to include heading tags (<h1>, <h2>, etc.) in your content. According to standard web design practices, an <h1> tag should be used at the beginning, followed by the <h2> tag, and so on. This means you can't use an <h3> tag without first including an <h1> and <h2>. Headings are important for organizing your content and making it more accessible to users, so be sure to include them in your webpage.

  <div class="summary-box-con">
  
  

  Another suggestion I have is to consider using a <ul> tag for the elements you currently have with identical properties. This can be helpful in creating a more responsive design, and could also result in a reduction in the amount of CSS required. By using children and type selectors in your CSS, you can target each element without needing to add a class attribute to them in your HTML. This can make your code more streamlined and easier to maintain in the long run.

  STYLE: 🎨🎨

  You considering using relative units like em and rem rather than fixed units like px for your styling because of the following :

  -Accessibility: Using relative units can improve accessibility for users who may need to increase the font size or zoom in on a web page. With relative units, the font and layout will adjust accordingly, making it easier for users to read and interact with the content.

  -Responsive design: Relative units can also make your design more responsive, as they allow your layout to adapt to different screen sizes and device types. This can be especially important for mobile devices, where screen sizes can vary significantly.

  -Consistency: Relative units can help maintain consistency across your design, as they ensure that fonts and layout elements are sized in proportion to each other. This can make your design look more polished and professional.

  -Scalability: Finally, using relative units can make your code more scalable and easier to maintain, as changes to font or layout sizes can be made in one place and affect the entire design.

  In conclusion, to make your design more centralized and compact, you might consider setting a max-height and max-width property for your main container. This can help ensure that your content is displayed in a consistent and visually appealing manner, especially on smaller screens.

  I hope these suggestions are helpful and will lead to an even better final product. Let me know if you have any further questions or need additional assistance!

  HAPPY CODING

  Marked as helpful

  0

  ---

  

  Boluwatife Bonaventure•550

  @BoyutifePosted over 1 year ago

  https://twitter.com/Boluwatife_Ven/status/1649000213762174979?s=20 @Boyutife you can Check this out for effective coding tips

  Marked as helpful

  0
• 

  Shivraj K•400

  @Shivraj-K09Posted over 1 year ago

  Your solution looks nice. I know it's hard to give names for classes. It's ok. Also practice CSS more because there is so much to learn in CSS. Try to use "bem naming convention" for CSS which will help you in the future. It is very good. and one more try to divide the solutions into small chunks. Go step-by-step from left to right. Try to solve the left side first and when you know it's good then go for right side. Keep Practicing and all the best for your journey.
  "Happy Coding" 😉

  Marked as helpful

  0