This is my first Frontend Mentor challenge. I have tried my best to write the code as DRY as possible. I would like some feedback if I could make it more optimised. This is my first time going with mobile-first workflow and I fallen in love with this approach. Any tips and suggestions on this are very welcome!
Michael Adebambo
@Blazing-MikeAll comments
- @paulauskas-linasSubmitted over 2 years ago@Blazing-MikePosted over 2 years ago
This looks great! It is mobile responsive and the validation works well. If you want improve it, you can work on the password validation to accepts on >= 6 characters ( and combination of letters, numbers and symbols). The CSS looks great as well !
1 - @MimieveshofuoSubmitted over 2 years ago
Feedbacks would be appreciated. Thanks.
@Blazing-MikePosted over 2 years agoGreat job you did here. Everything looks perfect, the only suggestion i have is the password input; it accepts an input of even two characters, in the password validation you can add that it returns an error for password <= 6 characters. If you want to go further you can add that it contains a combination of letters or symbols and numbers. Well-done Elizabeth
Marked as helpful1 - @Blazing-MikeSubmitted over 3 years ago
I TRIED MY BEST ON THIS ONE. YOUR FEEDBACKS ARE APPRECIATED
@Blazing-MikePosted over 3 years agoHmmn it's looks a bit distorted and I need to refactor the code
0 - @fame0100Submitted over 3 years ago
Suggestions and comments are welcome
@Blazing-MikePosted over 3 years agoGreat attempt 🚀🚀. You should check if your body by any means has margin because there are little spaces around the page..... Did you use different images for desktop and mobile? You can use the picture element or use media queries to display different image of viewports
0 - @EsmithASSubmitted over 3 years ago
Hey coders, si usted tiene algún comentario sobre mi solución, por favor deje un comentario. Muchas gracias!! 💻😎
@Blazing-MikePosted over 3 years agogrande tentative que vous avez eu ... Pixel parfait et pour détailler. continuons à nous améliorer et à construire
0 - @mraafat2021Submitted over 3 years ago
Please review the word and let me know your comments, it will help me improve as I am still a student. Thanks in advance.
@Blazing-MikePosted over 3 years agoOn your mobile view. The image section before the footer should have four images displayed horizontally. You can use display grid or flex for that section and also use media queries to tweak any element you want to on different viewports
LAYOUTS ( CSS GRID AND FLEXBOX) MEDIA QUERIES
0 - @mraafat2021Submitted over 3 years ago
Please review the word and let me know your comments, it will help me improve as I am still a student. Thanks in advance.
@Blazing-MikePosted over 3 years agoOn your mobile view. The image section before the footer should have four images displayed horizontally. You can use display grid or flex for that section and also use media queries to tweak any element you want to on different viewports
LAYOUTS ( CSS GRID AND FLEXBOX) MEDIA QUERIES
Marked as helpful0 - @Blazing-MikeSubmitted over 3 years ago
feedbacks are appreciated
@Blazing-MikePosted over 3 years agoNoted. I was just focused on the countdown, I got tired of the UI. I would make changes right away
0 - @Blazing-MikeSubmitted over 3 years ago
I TRIED TO GET THE LAYOUT BUT IT WAS TRICKY, FEEDBACKS ARE APPRECITED
- @DavidPorras043Submitted over 3 years ago
I appreciate your comments.
@Blazing-MikePosted over 3 years agoEverything works just fine 🌝. You could just align the container vertical to center on desktop mode.
With . container { Display grid; Justify Content: center; Align items : center; Min-height:100vh }
0 - @angelicambs9Submitted over 3 years ago
Qualquer feedback é bem vindo :)
@Blazing-MikePosted over 3 years agoGreat attempt you made. But the desktop site seem a bit distorted. You can check the height of the testimonial boxes and the spacing between the top container and bottom container
Marked as helpful1 - @rporfirio88Submitted over 3 years ago
I like feedbacks, in this way i can improve my front-end abilities! feel free to give me good constructive feedback.
@Blazing-MikePosted over 3 years agoOk great attempt you had... Try aligning your card like give it some space top and bottom.. you can use margin tip and bottom or use
Display: grid; Align-items: center; Min-height: 100vh; Justify-content: center;
To align it vertically and horizontally
Marked as helpful0