Responsive Price component using Grid

Community feedback

• 

  Amon•2,560

  @A-amonPosted over 3 years ago

  Hello! Great work~

  I have a few suggestions:

  1. There seems to be some horizontal overflowing to the right due to the before selector's image. Try using background-image for it.

  2. Instead of setting style directly in JS, add/remove or toggle class name instead.

  Having two separate spans for annual and monthly value each is a good idea. I could use some changes to my code using your way. You can try checking out mine on how to use CSS combinators to make it work without JS (Don't mind the duplicated lines of HTML. I will fix that based on your idea soon :) )

  https://www.frontendmentor.io/solutions/html-scss-toggle-without-js-g-y16l3KD

  1
• 

  Michael Adebambo•1,045

  @Blazing-MikePosted over 3 years ago

  Everything works fine 🌝... Great job.

  I tried reading through the code, it seems you used some ternary operators and some modern JavaScript syntax....

  1