HTML CSS

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  👋Hi Michael Adebambo!

  First rule as a developer, separate styling (CSS) from your HTML file. All styling should be in your main.css.

  Also please, do every challenge slowly and make sure it's already finished. That way, you will get more valuable feedback. This article from Matt Studdert (Creator of Frontend Mentor) will tell you a complete guide to submitting solutions on Frontend Mentor.

  Some more feedback:

  • Only use h1 at a time. So, use span inside the h1 and style it however you want would be better.
  • Try to learn Grid and Flexbox and then do this challenge again.
  • Please write a valid CSS, this is not valid:

  footer {
      text-align: center;
      font-weight: 900;
      te /* !!! */
  }
  

  • Try to use rem unit for the height or the width. The problem with vw and vh is that they're not consistent. Even better if you use padding with rem unit to control the size of the card.
  • Your indentation is not consistent, try to use Prettier to format your code.

  That's it! Hopefully this is helpful!

  Marked as helpful

  0
• 

  Amon•2,560

  @A-amonPosted over 3 years ago

  Hello! Great attempt~ That's a lot of hard work, doing it using transform. 😥 Try using grid for it.

  1
• 

  Michael Adebambo•1,045

  @Blazing-MikePosted over 3 years ago

  Thanks. I would refactor it

  0