Feedback welcome :)
Baliram
@0ME9AAll comments
- @yxwangOCRSubmitted almost 2 years ago@0ME9APosted almost 2 years ago
Hii! @yxwangOCR Congratulations bro.
Can you explain why you are using a blank h1 tag use can use a direct h2 tag because only one h1 tag should be on a page and there is also another reason that the h1 tag is used for the main title not for a secondary title?
Also, add <html lang="en"> in your HTML file.
We call it great practice and recommended by developers.
And brilliant job congratulations again Happy coding 🧑💻🎉🎉🎉
Marked as helpful0 - @fhero2030Submitted almost 2 years ago@0ME9APosted almost 2 years ago
Hi! @fhero2030
Conguralution man, you did it very well looks good, but did you forget that you must add an alternate attribute (alt) for the image tag? It's basic and recommended by most developers because it shows the attribute text when your image can't able to load or your image link is broken.
example: <img src="your image address" alt="Image not found"/>
Here alt displays its text at the position of the image "Image not found". There is also some other issue to fix here.
And yah nice job well-done bro Happy Coding 👍🧑💻
Marked as helpful1 - @bene-volentSubmitted about 2 years ago
- Any recommendation would be appreciated.
- Thank you for your time🙂
@0ME9APosted about 2 years agoHey Benevolent, congratulations on your solution!
Nice job...
#happyCoding🧑💻
1 - @sef1210Submitted about 2 years ago
Is there an easy way to center the element?
@0ME9APosted about 2 years agoHi @sef1210 !!!
Your design looks almost the same, and as a developer, I'm happy you did this. So now let's come to the point
There are several ways to center an element(s).
- display: flex, justify-content: center, align-items: center --(inside parent div/element)
- position: absolute, left: 50%, top: 50%, transform-translate: (-50%, -50%) --(apply in that div which you want to center and important apply position: relative ---------in parent div)
- margin: auto --(Horizontal align)
There are still more ways to center elements but I mostly use these css. #HappyCoding🧑💻
Marked as helpful0 - @vishalbrdrSubmitted about 2 years ago
This is my second attempt, cause I ran out of my API REQUESTS quota, but this time it's a different API, it got 500 requests/day, I think it will be enough.
Also handles errors this time.
@0ME9APosted about 2 years agoHi! @vishalbrdr,
It was hard for me to complete it using react, my map was not updating so I kept it simple and completed using jquery and sass. But I want to ask
Would you like to tell me which API you are using for Ip address?
0 - @Edinson25Submitted about 2 years ago
In this project I continue practicing bootstrap, I would like to know if someone can solve a doubt, I managed to make it look good on smartphones, but I feel that on a tablet the image would look somewhat stretched and the definition of the image is damaged
@0ME9APosted about 2 years agoHi!!! @Edinson25, I hope you enjoyed it and keep continue learning.
So first of all you should add your image inside a div and apply all styles on the div and on the image use width, height, and ".img-fluid" {bootstrap 5 class} and yes don't forget to add ".overflow-hidden" {bootstrap 5 class} on the parent of img tag.
parent div -> overflow-hidden and other classes child img tag -> img-fluid
Marked as helpful0 - @femiziSubmitted about 2 years ago
Should i add pagination?
@0ME9APosted about 2 years agoHi!!! @femizi,
I found something not great {error} on your site.
Try searching India and click {open detail window} You can see on click of India card it opens "British Indian Ocean Territory" but it shouldn't be.
0 - @Olumide2596Submitted about 2 years ago
Building the for was the easy part, it was figuring out the js for the validation I had a hard time with. Getting the error message to clear off after filling a field. I've been able to work it out though. Feedback on how to improve the code will be well appreciated 😁.
@0ME9APosted about 2 years agoHi! @Olumide2596,
You designed it very well it looks good. Not as same as the original design but it is perfect and you should do one more thing, align it vertically {not align vertically, especially on the big screen}.
0 - @Njabz-1Submitted about 2 years ago
Help, Couldn't get the mobile view to work correctly using bootstrap. Any tips for future? (I.e should one develop for mobile first or not etc.)
@0ME9APosted about 2 years agoHello @Njabz-1, You have to add (.flex-sm-column) in this element ⤵️
<div class="row justify-content-center mt-5"> and your card is not in center so center it.You Should Live Your site and correct the default readme file.
And of course, it's not too hard you can do it easily. 🙂
Marked as helpful1 - @0ME9ASubmitted about 2 years ago
I almost created this project in React the first time but the map was not updating so I completed it using jquery and sass and it worked perfectly. If anyone completed it in react please give me the source link. I need some hints in React.
@0ME9APosted about 2 years agoHii @DavidMorgade, Thank you for suggesting Documentation.
And yes it is hard to change the map location I mean LNG and LAT updates but map looks like they are fixed.
I spend 🤪 too much time searching for how to fix that bug but got nothing and finally finished 🧑💻 with basic tech HTML, sass, and jquery.
Now i'm going to learn that hook and your code too.
Thank you Bro one more time👍
1