QR code component solution: Vanilla HTML, CSS

Community feedback

• 

  David•8,000

  @DavidMorgadePosted about 2 years ago

  Hey Benevolent, welcome to the community and congrats on finishing the challenge!

  You did a pretty good job and got it almost pixel perfect on your first challenge, good job on that!

  As general fixes, try to don't manipulate the font-size on the :root, and if you do for any type of reason, is better to just do it on the body, because people with visuals problems will be a harder type adapting their screen if the default font-size is changed on the root!

  And also would recommend you to always use relative units like rems and ems instead of pixels for your sizes, paddings and margins!

  Apart from that, the rest is perfect in my opinion, jump on a harder challenge!

  Hope my feedback helped you!

  Marked as helpful

  2

  ---

  

  Benevolent•490

  @bene-volentPosted about 2 years ago

  @DavidMorgade thank you

  1
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  Hey Benevolent, congratulations for you solution!

  You've a really clean solution and great code. Two things you change to keep your code even more minimal is manage the CSS without using classes by selecting the h2 with his direct selector in the css sheet and give the bold styling without those 2 classes, I'm saying that because your code is already clean, doing that you make even more lightweight the css and html files.

  Great solution by the way and great start, looking forward for your next solutions.

  Hope this helps, happy coding 👏

  Marked as helpful

  1
• 

  Baliram•260

  @0ME9APosted about 2 years ago

  Hey Benevolent, congratulations on your solution!

  Nice job...

  #happyCoding🧑‍💻

  1