@DavidMorgade
Posted
Hey Benevolent, welcome to the community and congrats on finishing the challenge!
You did a pretty good job and got it almost pixel perfect on your first challenge, good job on that!
As general fixes, try to don't manipulate the font-size
on the :root
, and if you do for any type of reason, is better to just do it on the body
, because people with visuals problems will be a harder type adapting their screen if the default font-size is changed on the root!
And also would recommend you to always use relative units like rems
and ems
instead of pixels for your sizes, paddings and margins!
Apart from that, the rest is perfect in my opinion, jump on a harder challenge!
Hope my feedback helped you!
Marked as helpful
@bene-volent
Posted
@DavidMorgade thank you