@PhoenixDev22
Posted
Hi Sef Palima,
Congratulation on completing this challenge. Your solution looks great. I have some suggestions regarding your solution if you don’t mind:
- You can use
<main>
for the card and <footer> for the attribution. HTML5 landmark elements are used to improve navigation.
<main>
</main>
<footer>
</footer>
- In my opinion, the alternate text should indicate where the Qr code navigate the user : like
QR code to frontend mentor.
- Add
min-height: 100vh
instead ofheight: 100%
to the body that let the body grows taller if the content outgrows the visible page instead.
width: 330px
an explicit width is not a good way to have a responsive layout. Consider usingmax-width
to the card inrem
instead.
height: 500px
It's not recommended to set height to component, let the content of the component define the height.
Hopefully this feedback helps.
Marked as helpful
@sef1210
Posted
@PhoenixDev22 I'm having a hard time when I'm not setting the height but I will try next time :)
Thank you so much for your feedback highly appreciated :)