Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

News homepage (React && Sass)

Yixuan WANGβ€’ 240

@yxwangOCR

Desktop design screenshot for the News homepage coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback welcome :)

Community feedback

Baliramβ€’ 260

@0ME9A

Posted

Hii! @yxwangOCR Congratulations bro.

Can you explain why you are using a blank h1 tag use can use a direct h2 tag because only one h1 tag should be on a page and there is also another reason that the h1 tag is used for the main title not for a secondary title?

Also, add <html lang="en"> in your HTML file.

We call it great practice and recommended by developers.

And brilliant job congratulations again Happy coding πŸ§‘β€πŸ’»πŸŽ‰πŸŽ‰πŸŽ‰

Marked as helpful

0

Yixuan WANGβ€’ 240

@yxwangOCR

Posted

@0ME9A

Hi, Baliram,

Thanks for the feedback, I modified the h1 issue which should be unique!

As for why my h2 is empty, it is because I am using a reusable component (<Content/>) which can be used in "card" and "News block" where there is a blank line in "News block".

I will fix this issue ASAP.

Thanks again! Happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord