Latest solutions
Responsive Product Preview Card Component
Submitted 2 months agoI'd love feedback on if it's possible to achieve the same effect with less work on the media query.
Responsive Recipe Page with Pure CSS
Submitted 2 months agoAny feedback is welcome! However, I'd like feedback on how to optimize the CSS, HTML semantics, and accessibility.
Responsive social links profile using flexbox and media queries
Submitted 2 months agoAny feedback to improve the solution is welcome! Specially around HTML semantics, accessibility, or optimizing the CSS.
Blog preview card using flexbox
Submitted 2 months agoI'd like to improve the semantics and accessibility of my HTML, so any input on that is pretty much appreciated!
Responsive QR Code Card using Flexbox
Submitted 2 months agoAll feedback to improve the solution is welcome.
Latest comments
- @reemdalabSubmitted 2 months ago@zlowramPosted 2 months ago
I like how you decided to not wait until the size of the screen is 375px to change to the mobile version.
Additionally, there's a couple of things I saw that could be improved:
- The
PERFUME
product type should ideally be styled via CSS (text-transform
andletter-spacing
) - On the desktop design, the padding around the content could be a bit larger to let it breathe a bit.
- On the mobile version for screens with a width of 375px and a height of 667px a vertical scrollbar appears. Perhaps the design is too tall on this scale.
- Also, there is a mobile version of the picture which should be used when shifting the design from horizontal to vertical. I recommend checking here to learn how to use it.
Marked as helpful0 - The
- @navycdSubmitted 2 months ago@zlowramPosted 2 months ago
Something seems to be wrong with your solution: At least on Firefox the list of ingredients is all cramped.
Despite that, the design looks good even if some things are not accurate to the original design, such as fonts, the table styling, the preparation time box, etc.
0 - P@dmytro-gutorkaSubmitted 2 months ago@zlowramPosted 2 months ago
Great outcome!
I noticed how you used buttons to implement the links. It's nice to see a different way of doing it as I used an unordered list.
0 - P@ShanePinderDevSubmitted 2 months agoWhat specific areas of your project would you like help with?
Any suggestions for more semantic html tags and minimizing the amount of CSS would be great.
@zlowramPosted 2 months agoOverall the result looks good despite some minor differences with the original design:
- The border radius of the card is too low
- The
Learning
tag should have rounded corners - The padding on the card illustration is slightly lower than in the design
According to your feedback requests, for the reset I would go with the following, so it applies to all elements:
* { padding: 0; margin: 0; }
Also, I like how you used media queries here to adapt the design for mobile. I don't think it required it but it's a nice touch!
0 - @JinxCdevSubmitted 2 months ago@zlowramPosted 2 months ago
The solution looks good. At a visual level, being picky, I notice the following differences:
- The card seems a bit thinner than the one in the design
- The vertices of the card a little less rounded
Marked as helpful0