@dbzprimeSubmitted 2 months ago
Latest solutions
Blog Preview Card
PSubmitted 2 months agoAny suggestions for more semantic html tags and minimizing the amount of CSS would be great.
QR Code Component
PSubmitted 2 months agoI've submitted a solution for this before but it has been more than a year ago. I'm just restarting on Frontend Mentor using the learning paths.
Latest comments
- P@ShanePinderDevPosted 2 months ago
Great job!
I would just consider using a bit of margin-bottom between the main image and the div with the class of "content" as well as between the h2 and paragraph tags. Also, I would use a heavier font-weight for the h4 tag.
Marked as helpful0 - P@Alex-CDNLSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
Proud to have done this first project, to have found solution alone when i was stuck, to have learn a little bit git. And other stuff like netlify. Next time I'll be more careful about the style, i saw the file at the end, so I was wrong with the colors, the font size etc. Next time I will take my time to analyze the design to have a better HTML structure and CSS more organize.
What challenges did you encounter, and how did you overcome them?After putting the container horizontaly in the middle of the body, I didn't succeed to center it vertically. I used position absolute but it wasn't responsive anymore. I found in stack overflow and by playing with right click -> inspect how to center it vertically without using position absolute and having responsive design.
What specific areas of your project would you like help with?For a project like this with just main container in the middle of the screen, can we use flexbox on the body ? I saw debate in stack overflow to touch the body or not.
Do I needed to use a h1 ?
Was it possible to do the CSS with way less line ? Except for example using "padding : 0 0 0 10px" ?
P@ShanePinderDevPosted 2 months agoHi,
Great job! Your HTML and CSS are well-structured and readable. The solution looks like the provided design.
I used flexbox on the body in my solution to help with centering the component. Whether or not it should be used, I'm not sure. Hopefully, someone more experienced than me will answer that for you.
I also used a h1. Whether or not you choose to use an h1 depends, I think, on how you view the component. If you look at it as a stand alone component, then a h1 seems fine to me. If you view it as a component that will be inserted as a part of a larger page, then it would be better to use an h2 or h3 as that larger page will no doubt already have an h1 and you don't want 2 h1s on the same page.
I used about the same amount of CSS in my solution as you used in yours. I wouldn't worry about it at this stage. As we progress we will probably learn ways to use less but I think it's fine at this stage.
Marked as helpful1
