Responsive product preview card

Community feedback

• 

  AmIKamil•120

  @AmIKamilPosted 25 days ago

  for "perfume" instead of changing html you can use css text-transform: uppercase; so if you would change this paragraph in the future it is much easier to put just work in html and let css do his job fonts differs from ones that should be used, hover effect on button is missing you've used image-product-desktop.jpg only while another image should be used for mobile devices Please try to use semantic HTML, also you should work to keep your HTML clean and well tagged as it can help to write styles easier imv vs written part aren't equal, so you should catch up with flex a bit, however page is responsive and that was the main task Sorry that have indicated only negative sides of your work, but it is to help you to improve on those fields

  Marked as helpful

  0

  ---

  

  reemdalab•60

  @reemdalabPosted 25 days ago

  @AmIKamil Thank you for your feedback

  0
• 

  zlowram•90

  @zlowramPosted 26 days ago

  I like how you decided to not wait until the size of the screen is 375px to change to the mobile version.

  Additionally, there's a couple of things I saw that could be improved:

  • The PERFUME product type should ideally be styled via CSS (text-transform and letter-spacing)
  • On the desktop design, the padding around the content could be a bit larger to let it breathe a bit.
  • On the mobile version for screens with a width of 375px and a height of 667px a vertical scrollbar appears. Perhaps the design is too tall on this scale.
  • Also, there is a mobile version of the picture which should be used when shifting the design from horizontal to vertical. I recommend checking here to learn how to use it.

  Marked as helpful

  0
• 

  Anthonia Efe•160

  @AnthoniaEfePosted 26 days ago

  great job overall. I would suggest downloading the fonts in the style-guide.md file to have your solution look as close to the design as possible

  Marked as helpful

  0

  ---

  

  reemdalab•60

  @reemdalabPosted 25 days ago

  @AnthoniaEfe thank you

  0

  

  reemdalab•60

  @reemdalabPosted 25 days ago

  @AnthoniaEfe Thank you for your comment

  0