I found difficult the validation section of JS. I think it's a good challenge to a middle-newbie learner of JS. Just a couple difference of margins, paddings, font-sizes, etc., between the original design and my solution. Any feedback is welcome.
Mostafa Sayed
@zDevtutorAll comments
- @JoshMoonerSubmitted over 2 years ago@zDevtutorPosted over 2 years ago
Hi @JoshMooner, Well done my friend. It seems to work well and the page is fully responsive. However, I did take a look at the project files and I do have some recommendations.
- For the folder structure try to have an assets folder where you place all the assets there such as the "styles, images, videos, audios, scripts" and all should be in a specific folder.
- Try to rely more on semantic markups such as using the SECTION tag for different sections in the page markup so the code is more clear and standardized.
- You could try to add me media queries to the responsive.css file so it is only met when the user browses the file within the media query condition such as
Marked as helpful1 - @becckmanSubmitted over 2 years ago
I'm happy with the mobile, tablet and 1440px desktop resolution. However on bigger resolutions things start to look a little weird. My CSS got pretty much all over the place towards the end, I need a more controlled workflow.
@zDevtutorPosted over 2 years agoHey @becckman, Well done on the project here. I liked the animation part that you did. It makes things more interesting. One thing I noticed is that the background doesn't fill the full width and height of the page as it appears on the design and there is a little horizontal scroll exists in small to medium devices. I think taking care of this will help in improving the project.
Marked as helpful2 - @agusc01Submitted over 2 years ago
For me it was the easiest. But there is always something to improve. Tell me anything, it all adds up
@zDevtutorPosted over 2 years agoHey @aqusc01, Well done on the project here!. There are some improvements regarding the responsive part. The footer gets overlaps with the cards on some mobile devices. You could try to use the browser developer tool to check on that. On the medium screens between 700 to 900px the grey background doesn't fill the full width and height of the browser. I think by solving these two issues you're improving the project a lot.
Marked as helpful1 - @K4UNGSubmitted over 2 years ago
I wanted to try making a toggle in JavaScript and it was awesome. Any feedback or suggestion on how I can improve would be highly appreciated. Happy Coding!
@zDevtutorPosted over 2 years agoHey @k4ung Well done on the project here. It seems to be fully responsive. There are some improvements that you could implement. Try to rely on HTML5 semantic markups. You could try to have a header, footer, main as well as section tags to be used within the project here. Another thing that could be improved is the accessibility of the site. For example, you could try to improve the project accessibility by having all heading tags to be of descending order such as using h2 > h3 and not vice versa. I think these improvements will be helpful in the current project and future projects.
Marked as helpful0 - @aleksFedotovSubmitted over 2 years ago
Game has thrree difficulty levels: Easy: AI's move is decided solely based on Math.random() Normal: AI's move is decided through the minimax algorithm Hard: AI's move is decided through the minimax algorithm
Feedback will be highly appreciated
@zDevtutorPosted over 2 years agoHi @aleksFedotov, I really liked your approach to the game here. I did it using regular Math.random() and vanilla javascript. It's a nice feature to have a set of difficulties. I can try on that :). One thing I noticed here is that when the player plays against the CPU. The user is able to hover and click on the cell which got chosen before the CPU makes its move so this rewrites the CPU move.
Marked as helpful0 - @aleksFedotovSubmitted almost 3 years ago
Interesting challenge. Struggled with css part few times but in overall I liked it. I can't figure out why page screenshot is blank. Feedback will be highly appreciated
@zDevtutorPosted over 2 years agoHi @aleksFedotov, The game here isn't starting. It appears to be blank. Is there is something wrong with the game?
0 - @BenjaDotMinSubmitted almost 3 years ago
This was fun. I added some of my own twists on interaction, animation and UI. Just to give it a unique spin.
Thank you for your time!
@zDevtutorPosted over 2 years agoHi @BenjaDotMin, I really like the way you built the game, especially the part of you demonstrating CPU behavior by thinking. I did use this part from your project and linked it to you on the README file of it. However, I did use vanilla javascript for building the game here. One thing I noticed in your project is that when the user wants to play vs another player it actually kind of the same as playing vs CPU. And the scoreboard is not updated like the way on the design such as when the user wants to play vs another player. I think X should be (P1) and O should be (P2) and The winning and losing messages should be Player 1 wins or Player 2 wins. May I ask you to look at the code that I have regarding building this game and the logic that I used for building it? If you have any recommendations or improvements that I could do. This will be very helpful and beneficial for me.
Marked as helpful1