Design comparison
Solution retrospective
I wanted to try making a toggle in JavaScript and it was awesome. Any feedback or suggestion on how I can improve would be highly appreciated. Happy Coding!
Community feedback
- @othiagomoreiraPosted over 2 years ago
Good job! ✨
• When the mouse hovers over the button there is a small change in the layout, this is due to the fact that the border was added in the hover pseudo class, to fix it just add the border to the button element.
.btn, .btn-s { border: 2px solid white; } .btn-s:hover { background: transparent; color: var(--gradient-second); border-color: var(--gradient-second); }
Marked as helpful0@K4UNGPosted over 2 years ago@othiagomoreira Oh I was wondering how I could do that. Thanks for the feedback.
0 - @zDevtutorPosted over 2 years ago
Hey @k4ung Well done on the project here. It seems to be fully responsive. There are some improvements that you could implement. Try to rely on HTML5 semantic markups. You could try to have a header, footer, main as well as section tags to be used within the project here. Another thing that could be improved is the accessibility of the site. For example, you could try to improve the project accessibility by having all heading tags to be of descending order such as using h2 > h3 and not vice versa. I think these improvements will be helpful in the current project and future projects.
Marked as helpful0@K4UNGPosted over 2 years ago@zDevtutor Thanks for your detailed feedback. I'll keep semantic tags in mind next time. As for h2 > h3 tho, wouldn't it just increase the work? Or how does it improve the accessibility?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord