Form validation with JS

Community feedback

• 

  Mostafa Sayed•350

  @zDevtutorPosted over 2 years ago

  Hi @JoshMooner, Well done my friend. It seems to work well and the page is fully responsive. However, I did take a look at the project files and I do have some recommendations.

  • For the folder structure try to have an assets folder where you place all the assets there such as the "styles, images, videos, audios, scripts" and all should be in a specific folder.
  • Try to rely more on semantic markups such as using the SECTION tag for different sections in the page markup so the code is more clear and standardized.
  • You could try to add me media queries to the responsive.css file so it is only met when the user browses the file within the media query condition such as

  <link rel='stylesheet' media='screen and (max-width: 599px)' href='responsive.css' /> - You could try to avoid using normalize for resetting CSS and use a simple reset on the universal selector "*" since browsers are more intelligent now on parsing the CSS. - The js script works well for achieving the full validation of the form. However, there is much code duplication there. Try to use functions to separate your logic into dynamic pieces. The idea is to enhance and refactor the script by following the DRY principle. .. Hope that helps. Keep up the hard work!.

  Marked as helpful

  1