Ye-Won Seo
@yaywonahAll comments
- @Davi-logSubmitted 17 days ago@yaywonahPosted 17 days ago
Your code is well-structured and readable. However, I would change the fixed width of the
.container
div (width: 400px
) to a value under 375px, so that your card doesn't get cut off in mobile view.Marked as helpful0 - @cyber-mSubmitted about 1 month agoWhat are you most proud of, and what would you do differently next time?
It was my first time that I had to use the CSS counter() function, it was pretty useful in order to match the design of the ordered list.
@yaywonahPosted about 1 month agoI like how both your HTML and CSS is very neat and well-structured. Your solution looks similar to the design for both desktop and mobile. I liked that you used the CSS counter function to style the numbers in your ordered list!
0 - @toubayesSubmitted about 2 months agoWhat specific areas of your project would you like help with?
a aaaa i want heelp with this javascript and design
@yaywonahPosted about 2 months ago- I would add a
border-radius: 15px
property to the .out-card div to round the corners like in the solution. - change the color of the .header-card .job CSS to
color: var(--White);
- decrease the width of the .out-card div under
@media (min-width: 1200px)
so that it's not as wide when on desktop - decrease the font size of the <h1> title
Marked as helpful0 - I would add a
- @adrielson9Submitted about 2 months ago@yaywonahPosted about 2 months ago
Clean and neat code using semantic HTML and CSS. Layout looks good on both mobile and desktop. The only thing I'd suggest is centering the container vertically too, but overall it is accurate to the design.
0 - @Kaua-AlmeidaSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
me orgulho de ter conseguido finalizar em pouco tempo e ter resolvido alguns problemas de tamanho que estão desalinhados. Não sei o que mudaria.
What challenges did you encounter, and how did you overcome them?Não sabia como utilizar o Figma para pegar as informações do desafio mas fui procurando e consegui achar.
What specific areas of your project would you like help with?Gostaria de saber no que eu poderia melhorar quanto a medidas como px, vh, e %. As vezes e difícil saber qual usar.
@yaywonahPosted 2 months agoLooks good!
I would recommend this resource for more on px, vh, e, and %. Otherwise, using percentages is probably better for width, height, and padding, but I'm still a novice in this subject too.
Marked as helpful1