Skip to content
OverviewSolutions
20
Comments
15
Yash Joshi
@yashgjoshi20

All comments

  • Yash Joshi•450
    @yashgjoshi20Posted over 1 year ago

    Hey well done for completed this challenge😁

    I have some suggestions to help you to improve your solution :

    • You should add an <main> tag after body and before the div tags.
    • Instead of using <div class="container">, you should use <main class="container">
    • The <main> tag specifies the main content of a document.
    • You should put the <div class="attribution"> outside the <main> tag
    • Then replace the <div> tag by semantic tag <footer>
    • footer can contain information about author, copyright etc.

    HTML

    <body>
    <main class="container">
         <div> 
         </div>
    </main>

    <footer class="attribution">
     ....
    </footer>
</body>

    I hope you'll find this helpful, and your solutions is really good. 😌

    0
  • Yash Joshi•450
    @yashgjoshi20Posted over 1 year ago

    Hey well done for completed this challenge😁

    I have some suggestions to help you to improve your solution :

    • You should add an <main> tag after body and before the div tags.
    • Instead of using <div class="container">, you should use <main class="container">
    • The <main> tag specifies the main content of a document.
    • You should put the <div class="attribution"> outside the <main> tag
    • Then replace the <div> tag by semantic tag <footer>
    • footer can contain information about author, copyright etc.

    HTML

    <body>
    <main class="container">
         <div> 
         </div>
    </main>

    <footer class="attribution">
     ....
    </footer>
</body>

    I hope you'll find this helpful, and your solutions is really good. 😌

    Marked as helpful
    0
  • AnakonStar•40
    @AnakonStarSubmitted over 1 year ago

    I would like to know if my code is good enough to be hired, like, the correct use of tags and the way I positioned them.

    QR-CODE-Project

    2
    Yash Joshi•450
    @yashgjoshi20Posted over 1 year ago

    Hey well done for completed this challenge😁

    I have some suggestions to help you to improve your solution :

    • You should add an <main> tag after body and before the div tags.
    • The <main> tag specifies the main content of a document.
    • You should put the <div class="attribution"> outside the <main> tag
    • Then replace the <div> tag by semantic tag <footer>
    • footer can contain informations about author, copyright etc.

    HTML

    <body>
    <main>
    ....
    </main>

    <footer class="attribution">
    </footer>
</body>

    I hope you'll find this helpful, and your solutions is really good. 😌

    Marked as helpful
    1
  • Yash Joshi•450
    @yashgjoshi20Posted over 1 year ago

    Hey well done for completed this challenge😁

    I have some suggestions to help you to improve your solution :

    • You should add an <main> tag after body and before the div tags.
    • The <main> tag specifies the main content of a document.
    • You should put the <div class="attribution"> outside the <main> tag
    • Then replace the <div> tag by semantic tag <footer>
    • footer can contain informations about author, copyright etc.

    HTML

    <body>
    <main>
    ....
    </main>

    <footer class="attribution">
    </footer>
</body>

    I hope you'll find this helpful, and your solutions is really good. 😌

    Marked as helpful
    1
  • Yash Joshi•450
    @yashgjoshi20Posted over 1 year ago

    Hey well done for completed this challenge😁

    I have some suggestions to help you to improve your solution :

    • You should add an <main> tag after body and before the div tags.
    • The <main> tag specifies the main content of a document.
    • You should put the <div class="attribution"> outside the <main> tag
    • Then replace the <div> tag by semantic tag <footer>
    • footer can contain informations about author, copyright etc.

    HTML

    <body>
    <main>
    ....
    </main>

    <footer class="attribution">
    </footer>
</body>

    I hope you'll find this helpful, and your solutions is really good. 😌

    Marked as helpful
    1
  • Yash Joshi•450
    @yashgjoshi20Posted over 1 year ago

    Hey well done for completed this challenge😁

    I have some suggestions to help you to improve your solution :

    • You should add an <main> tag after body and before the div tags.
    • The <main> tag specifies the main content of a document.
    • You should put the <div class="attribution"> outside the <main> tag
    • Then replace the <div> tag by semantic tag <footer>
    • footer can contain informations about author, copyright etc.

    HTML

    <body>
    <main>
    ....
    </main>

    <footer class="attribution">
    </footer>
</body>

    I hope you'll find this helpful, and your solutions is really good. 😌

    0
  • Yash Joshi•450
    @yashgjoshi20Posted over 1 year ago

    Hey well done for completing this challenge😁

    I have some suggestions to help you to improve your solution :

    • You should replace the <div class="footer"> to <footer class="footer".
    • footer can contain information about author, copyright etc.
    <body>
    <footer class="footer">
    </footer>
</body>

    I hope you'll find this helpful, and your solutions is really good. 😌

    0
  • Dellenar•160
    @dellenarSubmitted over 1 year ago

    Hello There,

    It's been a month since i start learning how to code. If you have a time please review my code and let me know if something i should look into or if there is any method that I'm using wrong.

    Doing hover on image was pretty challenging but i managed to figure it out. As I keep doing these challenges i get more confidence on structure and using the modern css methods.

    Thank you in advance !

    NFT-Preview-Card-Compenent HTML+CSS

    1
    Yash Joshi•450
    @yashgjoshi20Posted over 1 year ago

    Hey well done for completed this challenge😁

    I have some suggestions to help you to improve your solution :

    • You should replace the <div class="attribution"> to <footer class="attribution".
    • footer can contain informations about author, copyright etc.
    <body>
    <footer class="attribution">
    </footer>
</body>

    I hope you'll find this helpful, and your solutions is really good. 😌

    0
  • Yash Joshi•450
    @yashgjoshi20Posted over 1 year ago

    Hey well done for completed this challenge😁

    I have some suggestions to help you to improve your solution :

    • You should add an <main> tag after body and before the div tags.
    • The <main> tag specifies the main content of a document.
    • You should put the <div class="attribution"> outside the <main> tag
    • Then replace the <div> tag by semantic tag <footer>
    • footer can contain informations about author, copyright etc.

    HTML

    <body>
    <main>
    ....
    </main>

    <footer class="attribution">
    </footer>
</body>

    I hope you'll find this helpful, and your solutions is really good. 😌

    Marked as helpful
    0
  • Yash Joshi•450
    @yashgjoshi20Posted over 1 year ago

    Hey well done for completed this challenge😁

    I have some suggestions to help you to improve your solution :

    1. You should add an <main> tag after body and before the div tags.
    2. The <main> tag specifies the main content of a document.
    3. You should put the <div class="attribution"> outside the <main> tag
    4. Then replace the <div> tag by semantic tag <footer>
    5. footer can contain informations about author, copyright etc.

    HTML

    <body>
    <main>
    ....
    </main>

    <footer class="attribution">
    </footer>
</body>

    CSS

    1. You should add an .attribute for footer
    2. Then in .attribute you can set the position to get the footer at center.
    0
  • Eunil•100
    @EunilCarlSubmitted over 1 year ago

    just built this after not coding for 2months and i forgot almost everything lol

    Order Summary Component

    1
    Yash Joshi•450
    @yashgjoshi20Posted over 1 year ago

    Hey well done for completed this challenge😁

    I have some suggestions to help you to improve your solution :

    1. You should put the <div class="attribution"> outside the <main> tag
    2. then replace the <div> tag by semantic tag <footer>
    3. footer can contain informations about author, copyright etc

    HTML

    <body>
     <main> 
      ....
     </main>

     <footer class="attribution">
     </footer>
</body>

    I hope you'll find this helpful, and your solutions is really good

    0
  • Yash Joshi•450
    @yashgjoshi20Posted over 1 year ago

    Hi There,

    I think you should add the favicon (i.e the little symbol on your tab) which shows the website icon you use. Its simple to add you just need to Declare a link in the header section of your HTML.

    <link rel="icon" href="favicon.ico">

    Hope I am Helpful. 😌

    Marked as helpful
    0