Skip to content
Submitted over 1 year ago

3 Column Preview Card Component - Solution

Eni•180
@EnidaShehu
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...3-column preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Any feedback is much appreciated :)

Community feedback

  • Yash Joshi•450
    @yashgjoshi20Posted over 1 year ago

    Hey well done for completed this challenge😁

    I have some suggestions to help you to improve your solution :

    • You should add an <main> tag after body and before the div tags.
    • The <main> tag specifies the main content of a document.
    • You should put the <div class="attribution"> outside the <main> tag
    • Then replace the <div> tag by semantic tag <footer>
    • footer can contain informations about author, copyright etc.

    HTML

    <body>
    <main>
    ....
    </main>

    <footer class="attribution">
    </footer>
</body>

    I hope you'll find this helpful, and your solutions is really good. 😌

    Marked as helpful
    0
  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    CSS 🎨:

    • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.
    • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states
    • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.
    • For this demonstration we use css Grid to center the component.
    body {
    min-height: 100vh;
    display: grid;
    place-items: center;
}
    • Now remove these styles, after removing you can able to see the changes
    .container {
  margin-top: 8rem;
}
    • Now your component has been properly centered

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord