Skip to content
Submitted over 1 year ago

QR-code

Souhail•40
@souhailsenini
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Yash Joshi•450
    @yashgjoshi20Posted over 1 year ago

    Hey well done for completed this challenge😁

    I have some suggestions to help you to improve your solution :

    • You should add an <main> tag after body and before the div tags.
    • The <main> tag specifies the main content of a document.
    • You should put the <div class="attribution"> outside the <main> tag
    • Then replace the <div> tag by semantic tag <footer>
    • footer can contain informations about author, copyright etc.

    HTML

    <body>
    <main>
    ....
    </main>

    <footer class="attribution">
    </footer>
</body>

    I hope you'll find this helpful, and your solutions is really good. 😌

    Marked as helpful
    1
  • Ecem Gokdogan•9,380
    @ecemgoPosted over 1 year ago

    Some recommendations regarding your code that could be of interest to you.

    In order to fix the accessibility issues:

    • You need to replace <div class="container"> with the <main class="container"> tag and <div class="attribution"> with the <footer class="attribution"> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
    • Each main content needs to include at least h1 element so you should use one <h1> element in the <main> tag. You can replace your <h3>Improve your front-end skills by building projects</h1> element with the <h1>Improve your front-end skills by building projects</h1> element.

    After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.

    Hope I am helpful. :)

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord