I didn't know I can make rating buttons being toggled one at a time with only HTML alone, so it was mind-opening. The concept of landmarks is still new to me, but I guess I need to learn that to give better accessibility to my website. Overall, it was my third project on this website and I enjoyed it.
wavegate
@wavegateAll comments
- @weebaoSubmitted over 2 years ago@wavegatePosted over 2 years ago
Nice catch on applying CSS to the checked radio button. I definitely chose to use JavaScript on an ordered list instead for that part which semantically is probably less effective. Can you explain how you lined up the number within each of the radio buttons in this line?
line-height: calc(0.25rem + 1rem);
I remember when I was doing this the numbers always were aligned a little off. Thanks.
1 - @BreinerJTSubmitted over 2 years ago
Any feedback is welcome!
@wavegatePosted over 2 years agoNice job on using semantic HTML. I would work on ensuring the obvious distortion in the width/height of the square image file, and make sure padding is consistent around all sides of the image to meet whitespace consistency, which will bring the design up a notch.
Marked as helpful0 - @normie614Submitted over 2 years ago
I just started learning HTML, CSS recently. If there is a more reliable way to do this with flexbox, please tell me, I'll be very grateful.
@wavegatePosted over 2 years agoGreat job. I like that your subtext is less strong than mine. My main suggestion is to look at accessibility for your HTML. Right now you just use <div> and <p> to split everything up. Instead, you should try to use more semantic HTML (tags with meaning) to improve accessibility and allow programs to read your site more easily.
I also chose not to use Flexbox because the margins all seemed to be inconsistent, so I think just using margins is fine.
Marked as helpful1