QR code component using flexbox

Community feedback

• 

  wavegate•220

  @wavegatePosted over 2 years ago

  Great job. I like that your subtext is less strong than mine. My main suggestion is to look at accessibility for your HTML. Right now you just use <div> and <p> to split everything up. Instead, you should try to use more semantic HTML (tags with meaning) to improve accessibility and allow programs to read your site more easily.

  I also chose not to use Flexbox because the margins all seemed to be inconsistent, so I think just using margins is fine.

  Marked as helpful

  1

  ---

  

  David•10

  @normie614Posted over 2 years ago

  @wavegate I updated the code. Can you tell me if that is a correct use of semantic tags for a card? Thanks for all your help!

  I decided to use flexbox because that is what I'm more comfortable with, hopefully soon enough I'll be able to identify and use a better alternative depending on the type of project.

  0

  

  wavegate•220

  @wavegatePosted over 2 years ago

  @normie614 Yes, nice job. I actually don't think semantics matters too much for a component like this (so I take my previous comment back), but I've realized it's more important for actual page layouts. I thought I knew some semantic elements but now that I'm getting to actual page layouts they make more sense to me: https://www.w3schools.com/html/html5_semantic_elements.asp. Best of luck to you.

  Marked as helpful

  1