wavegate

Latest comments

• 

  Bao Dang•110

  @weebaoSubmitted almost 3 years ago

  

  SASS and radio buttons learned

  1

  30
  

  wavegate•220

  @wavegatePosted almost 3 years ago

  Nice catch on applying CSS to the checked radio button. I definitely chose to use JavaScript on an ordered list instead for that part which semantically is probably less effective. Can you explain how you lined up the number within each of the radio buttons in this line?

  line-height: calc(0.25rem + 1rem);

  I remember when I was doing this the numbers always were aligned a little off. Thanks.

  1
• 

  BreinerJT•530

  @BreinerJTSubmitted almost 3 years ago

  

  QR code component

  2

  30
  

  wavegate•220

  @wavegatePosted almost 3 years ago

  Nice job on using semantic HTML. I would work on ensuring the obvious distortion in the width/height of the square image file, and make sure padding is consistent around all sides of the image to meet whitespace consistency, which will bring the design up a notch.

  Marked as helpful

  0
• 

  David•10

  @normie614Submitted almost 3 years ago

  

  QR code component using flexbox

  1

  40
  

  wavegate•220

  @wavegatePosted almost 3 years ago

  Great job. I like that your subtext is less strong than mine. My main suggestion is to look at accessibility for your HTML. Right now you just use <div> and <p> to split everything up. Instead, you should try to use more semantic HTML (tags with meaning) to improve accessibility and allow programs to read your site more easily.

  I also chose not to use Flexbox because the margins all seemed to be inconsistent, so I think just using margins is fine.

  Marked as helpful

  1