Skip to content
OverviewSolutions
4
Comments
4
Stefan Zorbas
@stezor

All comments

  • Stefan Zorbas•60
    @stezorPosted about 4 hours ago

    Except the font-family I think you did a good job. Btw I like how u comment css code, it really stands out.

    0
  • Stefan Zorbas•60
    @stezorPosted 1 day ago

    Hi. In my opinion there's plenty left to improve here, from html semantic structure to css selectors. For example social links are clearly group of links to other platforms, so unordered list with links inside ( ul>(li>a)*5 ) is the way to go I think. (Styled as buttons obviously). Even tho this project is really small I think regardless it's still best practice to use classes to target and style elements on the page opposed to element selectors, they are most general and slowest for that reason. Also both colors and font need more work so keep at it and best of luck.

    Marked as helpful
    0
  • Stefan Zorbas•60
    @stezorPosted 1 day ago

    Solution looks good, tho not the same as picture. It's hard to get it exactly right without all info such as font sizes etc. Several suggestions:

    • Downsize author picture.
    • Little less padding on "learning" tag.
    • At 375px width card shouldn't stretch whole width of the screen, so maybe instead of setting fixed width use relative instead but limit max-width. At least that's how I did it, not perfectly tho but close enough I think.
    0
  • Jye Harry•70
    @jyeharrySubmitted 13 days ago
    What are you most proud of, and what would you do differently next time?

    I think I made good use of BEM naming conventions for this simple little challenge. It's not necessary for this challenge but maybe I wouldn't create a .card__container class, but instead a more reusable container type class.

    What challenges did you encounter, and how did you overcome them?

    N/A

    What specific areas of your project would you like help with?

    No particular areas but open to any feedback regardless

    QR code challenge using flex and BEM

    1
    Stefan Zorbas•60
    @stezorPosted 5 days ago

    I think your solution looks great. Maybe react is overkill in this case although I understand if u wanted to practice it. Also I made body into a grid and then centered content, not to say your solution is worse with one extra element, I just like to have as few elements on the page as possible. I think h1 tag is too high semantically for card component, although I couldn't tell which one to use cause I'd like to learn that myself haha. I simply used p tags and styled 'em with css, which I think isn't great either. I think you did great job, but I had to write something cause I think we all learn best when exposed to as many ideas and perspectives as possible.

    0