@dar-juSubmitted 3 months ago
Sebastián Márquez
@sebamarquesAll comments
- @sebamarquesPosted 2 months ago
Hi, how are you?? i must tell you that your page looks really amazing, congrats, i really dont know what to say to you, i don't have a tip for you, but i learn the way you separate your css, it's really clever, i'm going to start using it as you, thanks for that!!.
0 - @AdamZajlerSubmitted over 3 years ago@sebamarquesPosted 2 months ago
the code looks good, i only see the image you have in your repository, if you did that good job! it really resembles the excercise, the only tip i could give you is to use BEM or any other naming methodologies: https://getbem.com/
0 - P@MinamakhloufSubmitted about 2 years ago@sebamarquesPosted 3 months ago
Good job!! i see that you completed this excercise two years ago, maybe this doesnt help too much but i recommend you using json instead of creating the object in the JS file, you can fetch it from your github repository, you go to the folder where the json is and select it, then you have options to the right where how much lines of codes you wrote, press the "raw" button and that's your link to fetch it, its like a server that you didn't create it but works like on so you can fetch your data from around the world without having to write it in your js.
0 - @TusharJetagiSubmitted 3 months ago@sebamarquesPosted 3 months ago
Good job!! it looks amazing, the only thing i would recommend you after looking at your css is using BEM methodology or any other for naming things so you can use it in your css instead of using element tags. https://getbem.com/. It's a methodology for making your HTML and css more readable!! good luck with your next project.
Marked as helpful1 - @jsemenborodasSubmitted 3 months ago@sebamarquesPosted 3 months ago
Hi how are you doing? i must say that you did a great job, good job,regardless i have 2 tips for you, first, using BEM or other naming method, so you dont use tags for styling, its a small project but for practice its very good, the other is to use em or rem, i see that you did in some parts of your css but in other lines i saw px or other absolute unit, its not bad to use them but most of the times its better to use relative units, everything else is incredible, i really liked it!!!
Marked as helpful1 - @SunilBaghel002Submitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I try to made next project more responsive
@sebamarquesPosted 6 months agoHi, great project!! i really liked it, only one thing, i saw that you don't use a methodologie to name your html classes, i recommend BEM, that's the one i'm using right now, there you have how to name you classes in a way that you will always remember or it will be easy to recognize, good look in your journey! and keep hard working. BEM site:https://getbem.com/
Marked as helpful0 - P@gianmromeroSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
My understanding about how grid layout works. I will change my way of doing my layout.
What challenges did you encounter, and how did you overcome them?How position my left and right containers in the grid. I read all the properties and apply what I learned.
What specific areas of your project would you like help with?Responsive units and media queries.
@sebamarquesPosted 6 months agoHi, you did a really good job, for the solution it's practically the same as the design we were given!!. But reading your html and your css i noticed that you don't use the BEM methodologie, there are a lot but that's the one i'm using right now: https://getbem.com/ and the video of kevin powell:https://www.youtube.com/watch?v=SLjHSVwXYq4 Everything else it's really good, great job
Marked as helpful0 - @wendyhamelSubmitted almost 2 years ago@sebamarquesPosted 6 months ago
Hi, it looks really great. It looks semantic, accessible, the only improvement i will do is adding meta tags to use for social webs, META group(Instagram,Facebook,etc):https://ogp.me/, for Twitter: https://developer.x.com/en/docs/x-for-websites/cards/overview/markup. I know it isn't a "real" web page but it's a good practice to get used to them, everything else is incredible. Great job!!
0 - @MrLanterSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I am proud to have introduced SCSS in my project. I struggled with quite a few compilation bugs but I always solved them.
What specific areas of your project would you like help with?Is my introduction to SCSS good?
Is my code well structured?
Is the semantics used well?
@sebamarquesPosted 7 months agoHi, how are you? congrats for the great job you did and for using SCSS, i never used SCSS so i don't think i'm comfortable talking about your code, but i see that in your design it misses the pink part in preparation and a line in Nutrition. I see that you used a span in <section class="instructions color-brown-800"> with a classname="strong", maybe instead of doing that you can use only a strong tag, i don't know why you did it that way, if you have a reason to do it like that forget what i say, from my point of view everything else it's great, good job
0 - @juan-mentorSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
- De empezar a hacer un código algo más accesible, aunque aún estoy en pañales.
- Como la card es un contenedor independiente a lo mejor sería más conveniente poner un article y subdividirla en un header, content y footer.
- En esta ocasión y gracias al aprendizaje obtenido a través de Learning Paths, no he tenido ninguna dificultad.
-
Quizás en el tema de accesibilidad, que me parece un gran acierto por parte de los desarrolladores.
-
Toda ayuda es bienvenida, al igual que todo comentario sobre por donde empezar a explorar dicho tema.
@sebamarquesPosted 7 months agoHola como estas? Primero felicitarte por tu pagina, son 2 gotas de agua con respecto al diseño de referencia. Mucho consejo no te puedo dar porque tambien estoy en pañales, pero lo que si puedo hacer es recomendarte una pagina donde podes ver un poco mas de HTML si tenes duda con meta tags, accesibilidad o etiquetas semanticas: https://lenguajehtml.com/html/
Marked as helpful0 - P@suarez8924Submitted 12 months agoWhat are you most proud of, and what would you do differently next time?
It was a quick component to work on.
What challenges did you encounter, and how did you overcome them?No significant challenges. Missed a couple of things like the height of the image being the same size for small and large screens, as well as the box-shadow, it also was different on large screens when hover state was active.
What specific areas of your project would you like help with?Feedback and recommendations are welcome
@sebamarquesPosted 7 months agoI saw it on live and i must say that i really liked what you did, i'm new in this so i don't think any comments i made will be helpful for you, but i will answer some questions.
- it's Semantic? Yes, but i learned that is recommended not starting the html with div, i saw your code and it starts with div class"root", maybe you you can change it for the semantics and for accesibility
- It looks amazing as i said.
- No, it looks exactly the same as the design, he changed how you interact with it, using a hover and a link for the title, which i liked, but the design it's like looking at a mirror
0 - @pauleenannSubmitted about 1 year ago@sebamarquesPosted 7 months ago
Hi, how are you? It looks incredible, the design it's exactly the same, 1)For the accesibilty i think it's good. 2)I changed the ranges of the page and it looks good. 3)The link for your repository it's broken or something like that, it gives a message that the repository doesn't exist so i used web tools cause, i don't have much experience in web development but from my point of view the only change i would make to your html code is in your "p" tag, inside it you used the "br" tag, and i think it's unnecesary, it's the only change i would do to it,if you wanted to occupy less space you could change the width of "p" tag to 60% or something like that instead of using "br" to give a new line, but everything else is incredible, good job!!
0
