Wendy• 1,890
@wendyhamel
Submitted
Sebastián Márquez
@sebamarques
All comments
@sebamarques
Posted
Hi, it looks really great. It looks semantic, accessible, the only improvement i will do is adding meta tags to use for social webs, META group(Instagram,Facebook,etc):https://ogp.me/, for Twitter: https://developer.x.com/en/docs/x-for-websites/cards/overview/markup. I know it isn't a "real" web page but it's a good practice to get used to them, everything else is incredible. Great job!!
0- MrLanter• 140
@MrLanter
Submitted
What are you most proud of, and what would you do differently next time?
I am proud to have introduced SCSS in my project. I struggled with quite a few compilation bugs but I always solved them.
What specific areas of your project would you like help with?
Is my introduction to SCSS good?
Is my code well structured?
Is the semantics used well?
@sebamarques
Posted
Hi, how are you? congrats for the great job you did and for using SCSS, i never used SCSS so i don't think i'm comfortable talking about your code, but i see that in your design it misses the pink part in preparation and a line in Nutrition. I see that you used a span in <section class="instructions color-brown-800"> with a classname="strong", maybe instead of doing that you can use only a strong tag, i don't know why you did it that way, if you have a reason to do it like that forget what i say, from my point of view everything else it's great, good job
0 - juan-mentor• 120
@juan-mentor
Submitted
What are you most proud of, and what would you do differently next time?
- De empezar a hacer un código algo más accesible, aunque aún estoy en pañales.
- Como la card es un contenedor independiente a lo mejor sería más conveniente poner un article y subdividirla en un header, content y footer.
What challenges did you encounter, and how did you overcome them?
- En esta ocasión y gracias al aprendizaje obtenido a través de Learning Paths, no he tenido ninguna dificultad.
What specific areas of your project would you like help with?
-
Quizás en el tema de accesibilidad, que me parece un gran acierto por parte de los desarrolladores.
-
Toda ayuda es bienvenida, al igual que todo comentario sobre por donde empezar a explorar dicho tema.
@sebamarques
Posted
Hola como estas? Primero felicitarte por tu pagina, son 2 gotas de agua con respecto al diseño de referencia. Mucho consejo no te puedo dar porque tambien estoy en pañales, pero lo que si puedo hacer es recomendarte una pagina donde podes ver un poco mas de HTML si tenes duda con meta tags, accesibilidad o etiquetas semanticas: https://lenguajehtml.com/html/
Marked as helpful
0 What are you most proud of, and what would you do differently next time?
It was a quick component to work on.
What challenges did you encounter, and how did you overcome them?
No significant challenges. Missed a couple of things like the height of the image being the same size for small and large screens, as well as the box-shadow, it also was different on large screens when hover state was active.
What specific areas of your project would you like help with?
Feedback and recommendations are welcome
@sebamarques
Posted
I saw it on live and i must say that i really liked what you did, i'm new in this so i don't think any comments i made will be helpful for you, but i will answer some questions.
- it's Semantic? Yes, but i learned that is recommended not starting the html with div, i saw your code and it starts with div class"root", maybe you you can change it for the semantics and for accesibility
- It looks amazing as i said.
- No, it looks exactly the same as the design, he changed how you interact with it, using a hover and a link for the title, which i liked, but the design it's like looking at a mirror
0- pauleenann• 240
@pauleenann
Submitted
Feedbacks are welcome.
@sebamarques
Posted
Hi, how are you? It looks incredible, the design it's exactly the same, 1)For the accesibilty i think it's good. 2)I changed the ranges of the page and it looks good. 3)The link for your repository it's broken or something like that, it gives a message that the repository doesn't exist so i used web tools cause, i don't have much experience in web development but from my point of view the only change i would make to your html code is in your "p" tag, inside it you used the "br" tag, and i think it's unnecesary, it's the only change i would do to it,if you wanted to occupy less space you could change the width of "p" tag to 60% or something like that instead of using "br" to give a new line, but everything else is incredible, good job!!
0
