Skip to content
OverviewSolutions
7
Comments
7
razanabbas
@razanabbas

All comments

  • f1r3•140
    @f1r3placeSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    I like how little CSS this whole thing took! The repo says I have more HTML than CSS, and I think that's great

    Don't really like that I couldn't get the spacing right and as a result there's a lot of empty space in the cards, but oh well

    testimonials grid using... css grid

    1
    razanabbas•100
    @razanabbasPosted 4 months ago

    Your design is very similar to mine. The cards are longer than they should be and idk how to fix that tbh.

    0
  • Markus•240
    @mhjarvisSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    Finally started using Grid instead of Flexbox for everything.

    What challenges did you encounter, and how did you overcome them?

    Mostly trying to get everything aligned with grid.

    Four Card Feature Challenge

    1
    razanabbas•100
    @razanabbasPosted 4 months ago

    great!

    1
  • razanabbas•100
    @razanabbasPosted 4 months ago

    You could've centered the card by turning the body to a grid and using place-content: center.

    0
  • razanabbas•100
    @razanabbasPosted 5 months ago

    The design is good overall but I have a few comments:

    1. The source document was not very satisfying to read. I think you could've done it with less divisions.
    2. I suggest you add some left padding for list items inside unordered lists.
    3. I also suggest you add some spacing between table rows.
    4. Your card is a bit wider than it should be. Try applying a max-width. That's all I personally have to say. I hope you benefit from my feedback.
    0
  • razanabbas•100
    @razanabbasPosted 5 months ago

    Does the solution include semantic HTML? Yes but imo the header could be divided into two sections: one for avatar and one for description Is it accessible, and what improvements could be made? Yes Does the layout look good on a range of screen sizes? I honestly do not currently have access to a range of screensizes Is the code well-structured, readable, and reusable? yes Does the solution differ considerably from the design? No

    0
  • razanabbas•100
    @razanabbasPosted 5 months ago

    Your code is semantically organized but I think the buttons should be edited in active not hover state.

    Marked as helpful
    0
  • razanabbas•100
    @razanabbasPosted 5 months ago

    Great!

    0