Newsletter sign-up form with success message, using scss, flex and js

Community feedback

• 

  razanabbas•150

  @razanabbasPosted about 2 months ago

  I think your code is neat and well-written

  0
• 

  P

  Carlos Samuel•310

  @CrtykwodPosted about 2 months ago

  First of all, congratulations for completing the challenge!!

  But there are, indeed, some problems that should be solved:

  • Don't include the TLDs in your email RegEx, an email like email@company.com.br being considered invalid is crazy, it basically exclude a country;
  • The main card isn't centered in desktop design and the background is white, although it should be pale navy;
  • What is the meaning of this <div class="main"> inside <main>?
  • A HTML list should be made with <ul>, <ol>, <li>, etc... if you plan to use a image as the list marker, make it the <li> background-image;
  • Always have a fallback font like sans-serif in case the user browser can't render Roboto;
  • Don't set your body height to 100vh, because it could break your website, instead, make it min-height: 100vh;. It will work better.

  ---

  That's all i noticed, sorry for any english mistakes i may have committed and, again, congrats for doing the project. Despite these mistakes, the javascript is working correctly and this is the important!!!

  0